Closed Bug 955654 Opened 10 years ago Closed 10 years ago

Error: (intermediate value).buddy is null at ibConvStatsService.js:479

Categories

(Instantbird Graveyard :: Conversation, defect)

x86
Other
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: aleth)

References

Details

(Whiteboard: [1.5-blocking])

Attachments

(1 file)

*** Original post on bio 2209 at 2013-10-09 16:53:00 UTC ***

Error: (intermediate value).buddy is null
Source File: resource://gre/components/ibConvStatsService.js
Line: 479
Blocks: 955013
*** Original post on bio 2209 at 2013-10-18 09:47:36 UTC ***

For STR, I would guess a PM with someone on IRC who isn't a buddy.
*** Original post on bio 2209 at 2013-11-04 17:58:35 UTC ***

(In reply to comment #1)
> For STR, I would guess a PM with someone on IRC who isn't a buddy.

That doesn't seem to be it. So this still needs STR...
Whiteboard: [1.5-blocking]
*** Original post on bio 2209 at 2013-11-07 12:28:37 UTC ***

See http://log.bezut.info/instantbird/131107/#m160
*** Original post on bio 2209 at 2013-11-09 11:44:33 UTC ***

So the problem is that when !conv.buddy, we don't have a possibleConv. 

Also, there is another bug here for MUCs (which doesn't throw an error) when _chatsByAccountIdAndName doesn't contain the MUC - _convsByPrplConvId is pointed at a null possibleConv.

Related: bug 955630 (bio 2185).
Attached patch PatchSplinter Review
*** Original post on bio 2209 as attmnt 3058 at 2013-11-16 18:06:00 UTC ***

Fixes the error for now, will need revisiting in bug 955630 (bio 2185).
Attachment #8354839 - Flags: review?(nhnt11)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment on attachment 8354839 [details] [diff] [review]
Patch

*** Original change on bio 2209 attmnt 3058 at 2013-11-16 18:24:28 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354839 - Flags: review?(nhnt11) → review+
Whiteboard: [1.5-blocking] → [1.5-blocking][checkin-needed]
*** Original post on bio 2209 at 2013-11-16 19:38:46 UTC ***

http://hg.instantbird.org/instantbird/rev/43a085f7cc76
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [1.5-blocking][checkin-needed] → [1.5-blocking]
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.