executeSoon calls pile up on addPendingChats, causing jank

RESOLVED FIXED in 1.5

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aleth, Assigned: aleth)

Tracking

Dependency tree / graph

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
*** Original post on bio 2218 at 2013-10-14 17:43:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
(Assignee)

Updated

5 years ago
Blocks: 955013, 955600
(Assignee)

Comment 1

5 years ago
Created attachment 8354727 [details] [diff] [review]
Patch

*** Original post on bio 2218 as attmnt 2947 at 2013-10-14 17:43:00 UTC ***

We should not delete the _addingPendingChats flag if we are calling executeSoon.
Attachment #8354727 - Flags: review?(nhnt11)
Comment on attachment 8354727 [details] [diff] [review]
Patch

*** Original change on bio 2218 attmnt 2947 at 2013-10-14 17:47:08 UTC ***

Thanks a lot for finding this bug!

I tested the patch, and it does take care of the jank problem.
Attachment #8354727 - Flags: review?(nhnt11) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 2218 at 2013-10-14 18:54:52 UTC ***

http://hg.instantbird.org/instantbird/rev/aad26a42a4ad
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.