Closed Bug 955665 Opened 7 years ago Closed 7 years ago

executeSoon calls pile up on addPendingChats, causing jank

Categories

(Instantbird :: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

References

Details

Attachments

(1 file)

*** Original post on bio 2218 at 2013-10-14 17:43:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Blocks: 955013, 955600
Attached patch PatchSplinter Review
*** Original post on bio 2218 as attmnt 2947 at 2013-10-14 17:43:00 UTC ***

We should not delete the _addingPendingChats flag if we are calling executeSoon.
Attachment #8354727 - Flags: review?(nhnt11)
Comment on attachment 8354727 [details] [diff] [review]
Patch

*** Original change on bio 2218 attmnt 2947 at 2013-10-14 17:47:08 UTC ***

Thanks a lot for finding this bug!

I tested the patch, and it does take care of the jank problem.
Attachment #8354727 - Flags: review?(nhnt11) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 2218 at 2013-10-14 18:54:52 UTC ***

http://hg.instantbird.org/instantbird/rev/aad26a42a4ad
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.