Closed Bug 955668 Opened 10 years ago Closed 10 years ago

Force-refresh open newtabs less frequently during LIST

Categories

(Instantbird Graveyard :: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

References

Details

Attachments

(1 file)

*** Original post on bio 2221 at 2013-10-15 21:04:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Blocks: 955013, 955600
Attached patch PatchSplinter Review
*** Original post on bio 2221 as attmnt 2955 at 2013-10-15 21:04:00 UTC ***

We currently force open newtabs to check whether they should display newly added possible conversations from LIST every 100ms. Since this can be quite expensive, this can cause jank.

The long-term solution is to make getFilteredConv and possibly _delayedRefresh async. This small change however gets rid of most of the jank, while still making it clear to the user that LIST results are being added (filtertext permitting).
Attachment #8354736 - Flags: review?(nhnt11)
Comment on attachment 8354736 [details] [diff] [review]
Patch

*** Original change on bio 2221 attmnt 2955 at 2013-10-16 08:40:21 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354736 - Flags: review?(nhnt11) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 2221 at 2013-10-18 11:13:40 UTC ***

http://hg.instantbird.org/instantbird/rev/5fcb26cc7453
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.