95567 - javascript strict warnings in enter_bug.cgi

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect, P3)

Description

[Henrik Gemal]

just go to:
http://bugzilla.mozilla.org/enter_bug.cgi?product=Webtools
and press Commit and you get:

Warning: function onclick does not always return a value
Source Code:
if (this.form.short_desc.value =='') { alert('Please enter a summary sentence
for this bug.'); return false; }

Comment 1

[Dave Miller [:justdave]]

Andreas, this sounds familiar, did we fix this and b.m.o just hasn't picked it
up, or is this something new?

Comment 2

[Andreas Franke (gone)]

I couldn't find this bug somewhere else, so I guess it's a new one.

Maybe you were thinking of bug 58436 ?

Comment 3

[Andreas Franke (gone)]

-> Bugzilla product, Creating Bugs component, reassigning.

Comment 4

[Henrik Gemal]

Attachment: Patch to fix warning...

Comment 5

[David D. Kilzer (ddk)]

*** Bug 118576 has been marked as a duplicate of this bug. ***

Comment 6

[David D. Kilzer (ddk)]

Changed milestone to 2.18...should get fixed in 2.16 with
templatization of enter_bug.cgi (bug 103953) anyway.

Comment 7

[Gervase Markham [:gerv]]

Fixed by the 103953 checkin. No JS warnings now that I can see.

Gerv

Comment 8

[Gervase Markham [:gerv]]

I spoke too soon. I didn't have JS strict warnings turned on. Sorry :-(

Gerv

Comment 9

[David D. Kilzer (ddk)]

Attachment: Patch v.2

Updated for use after enter_bug.cgi templatisation bug fix.

Comment 10

[Christian Reis]

Comment on attachment 67785 [details] [diff] [review]
Patch v.2

ready for checkin

Comment 11

[Christian Reis]

and thank god for linebreaks

Comment 12

[Gervase Markham [:gerv]]

Checked in.

Gerv

Comment 13

[Dave Miller [:justdave]]

fixing incorrect milestones on fixed bugs.