Closed
Bug 955689
Opened 10 years ago
Closed 10 years ago
[regression] Findbar chevrons swapped since moz25
Categories
(Instantbird Graveyard :: Other, defect)
Instantbird Graveyard
Other
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: aleth, Assigned: florian)
References
Details
(Whiteboard: [1.5-blocking])
Attachments
(1 file)
2.75 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 2241 at 2013-11-09 10:00:00 UTC *** The up/down buttons do the opposite of what they should. There are also some CSS issues on OSX and Windows.
Reporter | ||
Updated•10 years ago
|
Whiteboard: [1.5-blocking]
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 2241 as attmnt 3025 at 2013-11-10 01:49:00 UTC *** The 2 buttons used to have labels saying "Previous" and "Next" so we were purposefully swapping their behaviors. Now that they have icons pointing up/down, we don't want to swap their behavior when reversing the findbar, and we can just instead swap the behaviors of the previous/next keyboard shortcuts. The log viewer doesn't reverse the findbar so it its key bindings don't need to be swapped.
Attachment #8354806 -
Flags: review?(clokep)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → florian
Comment 2•10 years ago
|
||
Comment on attachment 8354806 [details] [diff] [review] Fix *** Original change on bio 2241 attmnt 3025 at 2013-11-10 01:52:20 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354806 -
Flags: review?(clokep) → review+
Comment 3•10 years ago
|
||
*** Original post on bio 2241 at 2013-11-10 03:11:27 UTC *** http://hg.instantbird.org/instantbird/rev/2773b8e9bccb
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in
before you can comment on or make changes to this bug.
Description
•