Closed Bug 955703 Opened 10 years ago Closed 10 years ago

Open conversations when joinChat is called for better responsiveness

Categories

(Chat Core :: IRC, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

References

Details

Attachments

(1 file, 4 obsolete files)

*** Original post on bio 2254 at 2013-11-22 15:16:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 2254 as attmnt 3066 at 2013-11-22 15:16:00 UTC ***

We currently only open a conversation for channels when JOIN is actually received from the server. If we already open the conversation when joinChat is called (and JOIN is sent to the server), this improves things in two ways:
- it feels more responsive (e.g. when clicking on a channel in the awesometab, a new tab immediately appears)
- it is more responsive (adding a tab takes time and we can do this while waiting for the server)
Attachment #8354847 - Flags: review?(clokep)
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 2254 as attmnt 3067 at 2013-11-22 16:45:00 UTC ***

An if clause was in the wrong place.
Attachment #8354848 - Flags: review?(clokep)
Comment on attachment 8354847 [details] [diff] [review]
Patch

*** Original change on bio 2254 attmnt 3066 at 2013-11-22 16:45:05 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354847 - Attachment is obsolete: true
Attachment #8354847 - Flags: review?(clokep)
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 2254 as attmnt 3068 at 2013-11-22 16:47:00 UTC ***

Should have rebased.
Attachment #8354849 - Flags: review?(clokep)
Comment on attachment 8354848 [details] [diff] [review]
Patch

*** Original change on bio 2254 attmnt 3067 at 2013-11-22 16:47:31 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354848 - Attachment is obsolete: true
Attachment #8354848 - Flags: review?(clokep)
Attached patch Patch2 (obsolete) — Splinter Review
*** Original post on bio 2254 as attmnt 3103 at 2013-11-30 15:08:00 UTC ***

We also want the rejoin message should we manage to rejoin after being kicked.
Attachment #8354886 - Flags: review?(clokep)
Comment on attachment 8354849 [details] [diff] [review]
Patch

*** Original change on bio 2254 attmnt 3068 at 2013-11-30 15:08:39 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354849 - Attachment is obsolete: true
Attachment #8354849 - Flags: review?(clokep)
Comment on attachment 8354886 [details] [diff] [review]
Patch2

*** Original change on bio 2254 attmnt 3103 at 2013-12-02 13:30:15 UTC ***

r+ with a comment above parted about how it's different from left (when should it be set, etc.) Yes, I know it's clear now...but I'm not going to remember when I look at this code in 3 months. :)

I'd really like most of this logic to be moved outside of the prpl so that MUCs are automatically reconnected, etc. and the IRC code doesn't do it itself.
Attachment #8354886 - Flags: review?(clokep) → review+
Attached patch Patch3Splinter Review
*** Original post on bio 2254 as attmnt 3108 at 2013-12-02 17:17:00 UTC ***

I think this matches what we want better and will make it easier to move the rejoining logic out of the prpl later.
Attachment #8354892 - Flags: review?(clokep)
Comment on attachment 8354886 [details] [diff] [review]
Patch2

*** Original change on bio 2254 attmnt 3103 at 2013-12-02 17:17:48 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354886 - Attachment is obsolete: true
Comment on attachment 8354892 [details] [diff] [review]
Patch3

*** Original change on bio 2254 attmnt 3108 at 2013-12-02 18:24:55 UTC ***

This looks OK, I'd like to test it before we check it in though.
Attachment #8354892 - Flags: review?(clokep) → review+
*** Original post on bio 2254 at 2013-12-03 00:24:53 UTC ***

http://hg.instantbird.org/instantbird/rev/356bd889969c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.