Closed Bug 955704 Opened 8 years ago Closed 8 years ago

Add MOZ_FINAL to avoid lots of clang warnings

Categories

(Chat Core :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: florian)

Details

Attachments

(1 file)

*** Original post on bio 2255 at 2013-11-23 18:33:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch PatchSplinter Review
*** Original post on bio 2255 as attmnt 3077 at 2013-11-23 18:33:00 UTC ***

Compiling purplexpcom causes clang to output plenty of noisy warnings like:
purpleAccount.cpp
/home/florian/buildhg/hg.instantbird.org/purple/purplexpcom/src/purpleAccount.cpp:87:1: warning: 
      delete called on 'purpleChatRoomField' that has virtual functions but non-virtual destructor
      [-Wdelete-non-virtual-dtor]
NS_IMPL_ISUPPORTS1_CI(purpleChatRoomField, prplIChatRoomField)
^
../../../mozilla/dist/include/nsIClassInfoImpl.h:163:3: note: expanded from macro
      'NS_IMPL_ISUPPORTS1_CI'
  NS_IMPL_RELEASE(_class)                                                     \
  ^
../../../mozilla/dist/include/nsISupportsImpl.h:506:40: note: expanded from macro 'NS_IMPL_RELEASE'
  NS_IMPL_RELEASE_WITH_DESTROY(_class, delete (this))
                                       ^
../../../mozilla/dist/include/nsISupportsImpl.h:486:5: note: expanded from macro
      'NS_IMPL_RELEASE_WITH_DESTROY'
    _destroy;                                                                 \
    ^


These are easy to fix, we just have to add MOZ_FINAL where needed.
Attachment #8354858 - Flags: review?(clokep)
Comment on attachment 8354858 [details] [diff] [review]
Patch

*** Original change on bio 2255 attmnt 3077 at 2013-11-23 18:35:58 UTC ***

I didn't test this, but it looks fine. rs=me.
Attachment #8354858 - Flags: review?(clokep) → review+
*** Original post on bio 2255 at 2013-11-23 19:10:42 UTC ***

http://hg.instantbird.org/instantbird/rev/769b8e95e228
Assignee: nobody → florian
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.