Closed
Bug 955710
Opened 10 years ago
Closed 10 years ago
Contact list context menu broken over the drop target
Categories
(Instantbird Graveyard :: Contacts window, defect)
Instantbird Graveyard
Contacts window
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: aleth, Assigned: aleth)
Details
Attachments
(1 file, 1 obsolete file)
1.05 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 2261 at 2013-11-29 14:39:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 2261 as attmnt 3100 at 2013-11-29 14:39:00 UTC *** The current code thinks it's a buddy.
Attachment #8354883 -
Flags: review?(florian)
Comment 2•10 years ago
|
||
Comment on attachment 8354883 [details] [diff] [review] Patch *** Original change on bio 2261 attmnt 3100 at 2013-12-01 17:08:05 UTC *** >diff --git a/instantbird/content/blist.js b/instantbird/content/blist.js > // Don't display a context menu on the headers. > this.shouldDisplay = localName != "label"; Maybe we could just test hasAttribute("dummy") here, and return early if we aren't going to display the context menu? > > this.onContact = localName == "contact"; > this.onBuddy = localName == "buddy"; >+ if (this.onBuddy & this.target.hasAttribute("dummy")) { You wanted && here, not &. >+ // We are over the drop target. >+ this.onBuddy = false; Wouldn't it be cleaner to do: > this.onBuddy = localName == "buddy" && !this.target.hasAttribute("dummy"); ? (if it's irrelevant if you follow the 'return early' suggestion ;)).
Attachment #8354883 -
Flags: review?(florian) → review-
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 2261 as attmnt 3114 at 2013-12-04 16:36:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354898 -
Flags: review?(florian)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8354883 [details] [diff] [review] Patch *** Original change on bio 2261 attmnt 3100 at 2013-12-04 16:36:23 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354883 -
Attachment is obsolete: true
Comment 5•10 years ago
|
||
Comment on attachment 8354898 [details] [diff] [review] Patch2 *** Original change on bio 2261 attmnt 3114 at 2013-12-04 23:35:40 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354898 -
Flags: review?(florian) → review+
Assignee | ||
Updated•10 years ago
|
Whiteboard: [checkin-needed]
Comment 6•10 years ago
|
||
*** Original post on bio 2261 at 2013-12-06 11:37:36 UTC *** http://hg.instantbird.org/instantbird/rev/42b2f2877357
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in
before you can comment on or make changes to this bug.
Description
•