Closed Bug 955716 Opened 10 years ago Closed 10 years ago

Delete all computed scores when log sweeping is complete

Categories

(Instantbird Graveyard :: Other, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

References

Details

(Whiteboard: [1.5-wanted])

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 2265 at 2013-12-03 17:41:00 UTC ***

If conversations are ongoing during log sweeping, various _computedScores will be set on possible conversations. We should delete these when log sweeping is complete, to ensure they are recalculated the next time computedScore is accessed (in order to take account of the log sweeping results).

Otherwise this leads to temporary low ranks for the affected conversations (the problem fixes itself the next time someone speaks).
Blocks: 955013
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 2265 as attmnt 3109 at 2013-12-03 18:54:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354893 - Flags: review?(nhnt11)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Whiteboard: [1.5-wanted][needs-review]
Attached patch Patch2Splinter Review
*** Original post on bio 2265 as attmnt 3111 at 2013-12-03 19:33:00 UTC ***

Move the delete to the end to be safe.
Attachment #8354895 - Flags: review?(florian)
Comment on attachment 8354893 [details] [diff] [review]
Patch

*** Original change on bio 2265 attmnt 3109 at 2013-12-03 19:33:46 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354893 - Attachment is obsolete: true
Attachment #8354893 - Flags: review?(nhnt11)
Comment on attachment 8354895 [details] [diff] [review]
Patch2

*** Original change on bio 2265 attmnt 3111 at 2013-12-03 19:37:32 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354895 - Flags: review?(florian) → review+
Whiteboard: [1.5-wanted][needs-review] → [1.5-wanted][checkin-needed]
*** Original post on bio 2265 at 2013-12-06 11:37:54 UTC ***

http://hg.instantbird.org/instantbird/rev/6a4d501de999
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [1.5-wanted][checkin-needed] → [1.5-wanted]
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.