Closed Bug 955720 Opened 10 years ago Closed 10 years ago

Fix up Yahoo strings

Categories

(Chat Core :: Yahoo! Messenger, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: clokep, Assigned: clokep)

Details

(Whiteboard: [1.5-blocking])

Attachments

(1 file)

*** Original post on bio 2269 at 2013-12-04 23:43:00 UTC ***

22:32:41 <flo-retina> I just gave a quick look at http://lxr.instantbird.org/instantbird/source/chat/locales/en-US/yahoo.properties
22:32:54 <flo-retina> I'll definitively have some review comments :-/
22:33:12 <flo-retina> "login.error.unknown=Unknown Error %S" needs at least a localization note.
22:33:26 <flo-retina> I've no idea of the context for "network.error.http=HTTP connection error."; why do we even need this?
22:33:47 <flo-retina> options.proxySSL should just be removed
22:33:57 <flo-retina> and probably options.chatLocale too
22:34:32 <flo-retina> I hope the options.transferHost/Port strings are never displayed in the UI (as we don't support file transfer), but it's not a problem if they are in the locales file; if we intend to use them eventually
22:34:46 <flo-retina> I don't think any user can understand what "Pager port" means.
22:34:56 <flo-retina> is this just meant to be "Port"?
22:38:16 <clokep> qheaden: ^
22:38:25 <clokep> I believe it's just "Port" though, yes.
22:38:28 <flo-retina> the HTTP error is from http://lxr.instantbird.org/instantbird/source/chat/protocols/yahoo/yahoo-session.jsm#595 The code doesn't seem to help much here. It seems a generic error. Note that the indent is wrong ;).
22:39:47 <clokep> I'd like qheaden to take a look at these, but if he doesn't have time I'll do a patch.
22:41:19 <flo-retina> clokep: don't bother rev'ing the string ids. I checked who localized this file already: only 2 localizers did, and I'm pretty sure they use the rss feed of en-US or something, so I think they can pickup changes even without id change.
22:41:29 <flo-retina> if they don't notice we'll email them; I'm sure they are responsive.
22:41:35 <clokep> flo-retina: Thanks. :)
Attached patch WIP v1Splinter Review
*** Original post on bio 2269 as attmnt 3115 at 2013-12-04 23:49:00 UTC ***

I wasn't sure what to do with network.error.http, so I just left it as is for now!
Attachment #8354899 - Flags: feedback?(florian)
Whiteboard: [1.5-blocking]
Comment on attachment 8354899 [details] [diff] [review]
WIP v1

*** Original change on bio 2269 attmnt 3115 at 2013-12-05 12:02:09 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354899 - Flags: feedback?(qheaden)
Comment on attachment 8354899 [details] [diff] [review]
WIP v1

*** Original change on bio 2269 attmnt 3115 at 2013-12-05 20:07:31 UTC ***

The patch looks good. As for the HTTP connection error, I do agree it is a bit generic. I can create separate error messages for each point of HTTP failure.
Attachment #8354899 - Flags: feedback?(qheaden) → feedback+
Comment on attachment 8354899 [details] [diff] [review]
WIP v1

*** Original change on bio 2269 attmnt 3115 at 2013-12-06 11:33:23 UTC ***

I think we will want to improve the "HTTP connection error." string before preffing on JS-Yahoo by default, but this is good enough for the 1.5 string freeze!
Attachment #8354899 - Flags: feedback?(florian) → review+
*** Original post on bio 2269 at 2013-12-06 11:37:16 UTC ***

http://hg.instantbird.org/instantbird/rev/0c4766236c4d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.