Closed Bug 955730 Opened 10 years ago Closed 10 years ago

LIST results don't always appear in awesometab

Categories

(Instantbird Graveyard :: Conversation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

Details

(Whiteboard: [1.5-blocking])

Attachments

(1 file)

*** Original post on bio 2279 at 2013-12-12 12:40:00 UTC ***

STR
Install a fresh IB.
Add irc.mozilla.org. 
Select "New conversation" to join a channel.
Result: Blank awesometab.
Expected result: Awesometab fills with LIST results.

As soon as one enters a filtertext, the results appear, so they are fetched correctly. But it seems there is an edge case where the display is not refreshed.

Makes for a bad first-run experience...
Summary: LIST results don't always appear by themselves → LIST results don't always appear in awesometab
Attached patch PatchSplinter Review
*** Original post on bio 2279 as attmnt 3121 at 2013-12-14 14:43:00 UTC ***

this.numberOfItemsToDisplay has to be calculated by resetItemsToDisplay in order for listitems to be added as necessary when the LIST results arrive.
Attachment #8354906 - Flags: review?(florian)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment on attachment 8354906 [details] [diff] [review]
Patch

*** Original change on bio 2279 attmnt 3121 at 2013-12-14 16:52:11 UTC ***

I won't claim to have in mind a full understanding of what's going on around this code, but I assume you do; and the change seems both reasonable and reasonably harmless :).
Attachment #8354906 - Flags: review?(florian) → review+
Whiteboard: [c
Whiteboard: [c → [1.5-blocking][checkin-needed]
*** Original post on bio 2279 at 2013-12-14 18:29:10 UTC ***

http://hg.instantbird.org/instantbird/rev/5bf050c5bb25
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [1.5-blocking][checkin-needed] → [1.5-blocking]
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.