955790 - Block updates from Instantbird 1.1 to 1.2 for Windows 2000 and Windows XP < SP2 users

Status: RESOLVED FIXED

(Instantbird Servers Graveyard :: update.instantbird.org, defect)

Description

[Florian Quèze [:florian]]

*** Original post on bio 1435 at 2012-05-16 13:27:00 UTC ***

We have changed our Windows compiler to MSVC2010 a while ago; the binaries generated by this compiler require at the minimum Windows XP SP2.

Comment 1

[Quentin Raynaud]

*** Original post on bio 1435 at 2012-05-16 13:33:07 UTC ***

It is not always because it is not officially supported that it doesn't work. Has it been tested out that our current binaries are plain not working with Windows XP SP0 & 1. I would not be surprised if it still worked. And I don't believe we still have Win2000 users of Ib.

Comment 2

[Florian Quèze [:florian]]

*** Original post on bio 1435 at 2012-05-16 13:44:51 UTC ***

(In reply to comment #1)
> It is not always because it is not officially supported that it doesn't work.
> Has it been tested out that our current binaries are plain not working with
> Windows XP SP0 & 1.

The CRT dll files require symbols that don't exist in previous kernels to load. These symbols aren't really very useful, but Mozilla gave up on the idea of hacking the CRT dlls to remove the dependency of these symbols, so I don't think we will be in a position of doing it.

> And I don't believe we still have Win2000 users of Ib.

We probably don't have many of them. But my mother's old laptop hasn't died yet ;).

Comment 3

[Patrick Cloke [:clokep]]

*** Original post on bio 1435 at 2012-06-19 18:28:16 UTC ***

Does this require a code change or is it just a configuration thing? If it's a code change...where does the code for the update script live?

Comment 4

[Florian Quèze [:florian]]

*** Original post on bio 1435 at 2012-08-03 16:23:56 UTC ***

For the code part, we need to port http://hg.mozilla.org/comm-central/rev/3d0f34d6e962 from https://bugzilla.mozilla.org/show_bug.cgi?id=723317

This is trivial :-).

If it applies easily, we could maybe also port http://hg.mozilla.org/comm-central/rev/7ec79765fce9 Some Win7 users may be happy about that if we did.

Comment 5

[Patrick Cloke [:clokep]]

*** Original post on bio 1435 at 2012-08-03 21:23:55 UTC ***

I'm working on this.

Comment 6

[Patrick Cloke [:clokep]]

Attachment: Ports both changesets

*** Original post on bio 1435 as attmnt 1784 at 2012-08-04 13:55:00 UTC ***

This patch does not include the hunks of http://hg.mozilla.org/comm-central/rev/7ec79765fce9 at lines 598 and 734 of shared.nsh because we don't seem to have corresponding sections (598 is the one to migrate shortcuts from a subfolder to the root of the Start Menu).

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 8354947 [details] [diff] [review]
Ports both changesets

*** Original change on bio 1435 attmnt 1784 at 2012-08-04 17:56:51 UTC ***

Thanks!

Comment 8

[Patrick Cloke [:clokep]]

*** Original post on bio 1435 at 2012-08-04 18:54:31 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/53da52bca6f6

Does this also need website updates?

Comment 9

[Florian Quèze [:florian]]

*** Original post on bio 1435 at 2012-08-04 20:16:57 UTC ***

Yes, on http://instantbird.com/system-requirements.html

Comment 10

[Patrick Cloke [:clokep]]

Attachment: Website patch

*** Original post on bio 1435 as attmnt 1787 at 2012-08-04 21:21:00 UTC ***

(In reply to comment #9)
> Yes, on http://instantbird.com/system-requirements.html

Remove Windows 2000 from the list of supported versions and changed "XP" to "XP SP 2".

Comment 11

[Florian Quèze [:florian]]

Comment on attachment 8354948 [details] [diff] [review]
Website patch

*** Original change on bio 1435 attmnt 1787 at 2012-08-04 21:38:26 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 12

[Patrick Cloke [:clokep]]

*** Original post on bio 1435 at 2012-08-08 14:33:34 UTC ***

Committed website changes as http://hg.instantbird.org/websites/www.instantbird.com/rev/3bc605a80be0