955818 - rootanalysis and ggc fail to build for non-nightly config

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/?tree=Try&rev=54ef3ee8c675 is current mozilla-central pushed to try as though it had been merged to mozilla-aurora, with all the nightly-only switches flipped off.

https://tbpl.mozilla.org/php/getParsedLog.php?id=32427981&tree=Try and https://tbpl.mozilla.org/php/getParsedLog.php?id=32428003&tree=Try say that rootanalysis and ggc won't build that way. Dunno whether that's critical with a February 3rd deadline because they're following the trains this next merge, or just something that needs to be fixed someday.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug955818-aurora-ggc-build-failure

I don't know why this doesn't cause a problem already, but we need to #include ScopeObject.h to make this work.  Here's a patch.

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 8355165 [details] [diff] [review]
bug955818-aurora-ggc-build-failure

Review of attachment 8355165 [details] [diff] [review]:
-----------------------------------------------------------------

Weird indeed. Maybe the unified builds are to blame? r=me

Comment 3

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/860cdf1c7ada

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/860cdf1c7ada