Closed Bug 955842 Opened 7 years ago Closed 7 years ago

Disable OS X Address Book testing in xpcshell-tests due to 10.8 and later issues

Categories

(MailNews Core :: Testing Infrastructure, defect)

All
macOS
defect
Not set
normal

Tracking

(thunderbird27 fixed, thunderbird28 fixed, thunderbird_esr2427+ fixed)

RESOLVED FIXED
Thunderbird 29.0
Tracking Status
thunderbird27 --- fixed
thunderbird28 --- fixed
thunderbird_esr24 27+ fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file, 1 obsolete file)

The current xpcshell tests for the address book only really test the fact the OS X Address book is in preferences, and some of the outlying things work, e.g. the name of the book and some of its properties (e.g. read-only) are correct.

The 10.8 xpcshell-tests (currently hidden) are broken, because the builders can't access the OS X Address Book due to the new permissions system that Apple brought in and I can't find a way in which we could set up the builders to avoid it.

In any case, the OS X Address Book tests aren't currently adding much value, and two out of three of the instances aren't actually testing anything due to relying on detecting OS X by the old rdf uris rather than the newer component URIs.

Hence, lets just disable OS X Address Books in tests, and then we should be able to get 10.8 xpcshell-tests mainly green.
Attached patch Proposed Fix (obsolete) — Splinter Review
This disables OS X in the tests (also note: we could never test the contents of the Mac address book, as that would require altering the user's local AB which would be risky).

Try server run is here:

https://tbpl.mozilla.org/?tree=Thunderbird-Try&showall=1&rev=a7f230191e01

You can compare with trunk with:

https://tbpl.mozilla.org/?tree=Thunderbird-Trunk&showall=1
Attachment #8354992 - Flags: review?(mconley)
Attached patch Proposed Fix v2Splinter Review
v2 - I'd missed a couple of tests, adding abSetup.js should disable the OS X AB for those tests. New try server push:

https://tbpl.mozilla.org/?tree=Thunderbird-Try&showall=1&rev=0f12a01d8eff
Attachment #8354992 - Attachment is obsolete: true
Attachment #8354992 - Flags: review?(mconley)
Attachment #8355001 - Flags: review?(mconley)
Try server runs are green.
Comment on attachment 8355001 [details] [diff] [review]
Proposed Fix v2

Review of attachment 8355001 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me. Thanks Mark!
Attachment #8355001 - Flags: review?(mconley) → review+
https://hg.mozilla.org/comm-central/rev/96da5e8ea9e0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
Comment on attachment 8355001 [details] [diff] [review]
Proposed Fix v2

[Triage Comment]
This is test-only, so taking onto all branches so we can make visible the 10.8 xpcshell builders on those branches (and cut down the current length of builds that they take, the timeouts make these ~ 120 mins, with this fixed, we get ~ 20 mins).
Attachment #8355001 - Flags: approval-comm-esr24+
Attachment #8355001 - Flags: approval-comm-beta+
Attachment #8355001 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.