Closed Bug 955875 Opened 10 years ago Closed 10 years ago

Permanent Orange: Mac 10.8 TEST-UNEXPECTED-FAIL | test-attachment-reminder.js::test_attachment_reminder_dismissal (and test_attachment_reminder_aggressive_pref, test_no_send_now_sends)

Categories

(Thunderbird :: Testing Infrastructure, defect)

All
macOS
defect
Not set
normal

Tracking

(thunderbird27 fixed, thunderbird28 fixed, thunderbird_esr2427+ fixed)

RESOLVED FIXED
Thunderbird 29.0
Tracking Status
thunderbird27 --- fixed
thunderbird28 --- fixed
thunderbird_esr24 27+ fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file, 1 obsolete file)

These have been perma-fail on Mac 10.8:

TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/mozmill/composition/test-attachment-reminder.js | test-attachment-reminder.js::test_attachment_reminder_dismissal
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/mozmill/composition/test-attachment-reminder.js | test-attachment-reminder.js::test_attachment_reminder_aggressive_pref
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/mozmill/composition/test-attachment-reminder.js | test-attachment-reminder.js::test_no_send_now_sends

Generally with a:

Test Failure: Timeout waiting for modal dialog to open.

before them.

My current suspicions are that these are due to "tinderbox" being a valid hostname on those hosts, so Thunderbird is actually trying to contact them.

I've some try server builds underway that seem to indicate this is so, and I'm currently trying to get a patch that builds with an alternate hostname that won't resolve.
Attached patch The fix (obsolete) — Splinter Review
It appears my hunch was right - the 10.8 Mozmill builders do have "tinderbox" as some sort of valid hostname. Changing to "tinderbox123" gets these tests working again.

There's also a bit of constant addition where we can, so that its easier to change in future.

Try server:

https://tbpl.mozilla.org/?tree=Thunderbird-Try&showall=1&rev=d7e743dae61c
Attachment #8355033 - Flags: review?(mconley)
Comment on attachment 8355033 [details] [diff] [review]
The fix

Review of attachment 8355033 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=me with a weak request to move the const into folder-display-helpers. I'm open to argument on it, but folder-display-helpers has been where we've stashed other common utility stuff. Might as well keep it all together.

::: mail/test/mozmill/shared-modules/test-window-helpers.js
@@ +21,5 @@
>  
>  /**
> + * Server hostname as set in runtest.py
> + */
> +const FAKE_SERVER_HOSTNAME = 'tinderbox123';

window-helpers seems a strange place to put this... folder-display-helpers has kind of been our catch-all up until now. How do you feel about putting it there instead?
Attachment #8355033 - Flags: review?(mconley) → review+
Attached patch The fix v2Splinter Review
I agree, folder-display-helpers is the better place to put this. I've updated the patch and tested it locally.
Attachment #8355033 - Attachment is obsolete: true
Attachment #8355082 - Flags: review+
https://hg.mozilla.org/comm-central/rev/c2b7a79bf4fd
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
Comment on attachment 8355082 [details] [diff] [review]
The fix v2

[Triage Comment]
Builders are green on trunk. Getting this onto aurora so that we can unhide builders there as well :-)

Will do the rest of the branches tomorrow once Windows is verified on aurora.
Attachment #8355082 - Flags: approval-comm-aurora+
Comment on attachment 8355082 [details] [diff] [review]
The fix v2

[Triage Comment]
Looks good on aurora, so taking to beta & esr24 as this is test-only.
Attachment #8355082 - Flags: approval-comm-esr24+
Attachment #8355082 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.