955983 - HTML5 Video player doesn't provide dir=rtl to error messages

Status: RESOLVED DUPLICATE of bug 1543828

(Toolkit :: Video/Audio Controls, defect)

Description

[Tomer Cohen :tomer]

Attachment: screenshot

When the HTML5 Video player fail to load, we receive an error message that lacks dir=rtl. While we can workaround it by adding RLE..PDF around the message(s), more elegant solution is required!

Steps to reproduce: (borrowed from bug 955980 ☺)
1. Disable Flash Player from the Addons → Plugins page. 
2. Visit http://www.ynet.co.il/articles/0,7340,L-4464398,00.html

Actual result:
Error message "תסדיר הווידאו או סוג ה־MIME אינו נתמך." ("Video format or MIME type is not supported."). 

Expected result:
Error message "תסדיר הווידאו או סוג ה־MIME אינו נתמך.".

Comment 1

[Tomer Cohen :tomer]

(In reply to Tomer Cohen :tomer from comment #0)
> Expected result:
> Error message "תסדיר הווידאו או סוג ה־MIME אינו נתמך.".
Well, that's weird. Bugzilla have removed the RLE..PDF control characters I placed in the previous comment. Anyway, imagine that the word "תסדיר" is the first word at the right side of the string, and the last word is "נתמך.", while the period is the last and leftmost character in the string.

Comment 2

[Tomer Cohen :tomer]

Attachment: Testcase (empty .webm file)

Comment 3

[Tomer Cohen :tomer]

https://dxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/videocontrols.css#25,72
https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/media/videocontrols.css#459

Comment 4

[Tomer Cohen :tomer]

Attachment: Bug 955983 HTML5 Video player doesn't provide dir=rtl to error messages

Review commit: https://reviewboard.mozilla.org/r/100996/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100996/

Comment 5

[Francesco Lodolo [:flod]]

@Tomer
Are you still interested in fixing this? I assume this will need a rebase at this point, and a reviewer, otherwise nobody will really look into it. Since this is not a bug in the Hebrew translation, it should also live in a Code component (moving it to Toolkit::Video/Audio controls, hoping it's the right one).

Potential reviewers
https://hg.mozilla.org/mozilla-central/log/tip/toolkit/content/widgets/videocontrols.css

Comment 6

[Itiel]

Fixed by bug 1543828.