Closed
Bug 955991
Opened 10 years ago
Closed 10 years ago
[Gaia][Build] Unit Test for settings.js
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gduan, Assigned: gduan)
Details
Attachments
(1 file)
Add unit test for settings.js.
|
Assignee | |
Comment 1•10 years ago
|
||
Hi Yuren, please kindly check this patch. It should have covered most cases. thanks.
Attachment #8355183 -
Flags: superreview?(yurenju.mozilla)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → gduan
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8355183 -
Flags: superreview?(yurenju.mozilla) → review?(yurenju.mozilla)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8355183 [details]
PR to master
Hi George,
This pr looks very good! r=yurenju, and I think you can use the same test criteria for integration test of settings.js, we can create a module to generate expected settings properties and using it both in unit test and integration test.
Attachment #8355183 -
Flags: review?(yurenju.mozilla) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Thanks Yuren, I'll open a but for integration test for it! https://github.com/mozilla-b2g/gaia/commit/690275d455d210ed781cbbbbfc789ad3ca7a54c8
|
|
Assignee | |
Comment 4•10 years ago
|
||
Follow-up bug bug 968070 for integration test.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•