955992 - Running install-gaia.js on node.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

+++ This bug was initially created as a clone of Bug #955988 +++

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

In bug 956004 , install-gaia.js is already able to run on nodejs, however, we still have some problem running on Windows.
I'll take getPid function to utils-xpc and utils-node to fix this bug.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

WIP.

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

attachment 8359910 [details] has implemented Promise pattern in order to run command line synchronously.

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8359910 [details]
PR to master

Hi Yuren,

this patch has implemented promise pattern to replace execSync module. I've already tested in windows and mac, so I think it's ready to be reviewed.

please kindly check it.
thanks.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8359910 [details]
PR to master

George, we should make this pull request more readable and try to avoid using shell too much, we should consider running build script on Windows without MinGW in future.

left some comments on github and please feel free to discuss with me.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8359910 [details]
PR to master

Hi Yuren,

patch is updated. Please kindly check again.

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

In Windows, all the files inside the zip have prefix '\', so I cannot read the manifest and close app successfully, I think it's related to bug 957497, since I tried to revert it and the pb's gone.

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8359910 [details]
PR to master

George, looks we can't guarantee sequence of Commander.run in utils-node is same as we called.

I added a console.log after utils-node.js:72 (after q.resolve()) and got:
> adb start-server
> adb shell stop b2g
> adb shell rm -r //cache/*
> adb shell rm -r //system/b2g/webapps
> adb shell rm //data/local/user.js
> adb push "/Users/yurenju/Documents/workspace/gaia/profile/webapps" //system/b2g/webapps
> adb push "/Users/yurenju/Documents/workspace/gaia/profile/user.js" //data/local/user.js
> adb shell start b2g
>  
> done: [ adb start-server]
> done: [ adb push "/Users/yurenju/Documents/workspace/gaia/profile/user.js" //data/local/user.js]
> done: [ adb shell stop b2g]
> done: [ adb shell start b2g]
> done: [ adb shell rm //data/local/user.js]
> done: [ adb shell rm -r //cache/*]
> done: [ adb shell rm -r //system/b2g/webapps]
> done: [ adb push "/Users/yurenju/Documents/workspace/gaia/profile/webapps" //system/b2g/webapps]

please check that.

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8359910 [details]
PR to master

Hi Yuren,
I have updated, please kindly check again. thanks.

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

Basically, I forgot to return defer.promise in each .run(), so, the queue will not actually stop in each then function. New patch has fix this pb.

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8359910 [details]
PR to master

r=yurenju, please add more comments in install-gaia.js for reading easily.

Comment 12

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks Yuren,
merge into master
https://github.com/mozilla-b2g/gaia/commit/8b906d20082c3dfa636f0ef8b69ca9ce0b272ce2