Closed
Bug 955996
Opened 11 years ago
Closed 9 years ago
Running svoperapps.js on node.js
Categories
(Firefox OS Graveyard :: Gaia, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yurenju, Assigned: rickychien)
References
Details
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #955988 +++
|
Assignee | |
Updated•9 years ago
|
Summary: Running variant.js on node.js → Running svoperapps.js on node.js
|
|
Assignee | |
Updated•9 years ago
|
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → ricky060709
Status: NEW → ASSIGNED
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8568974 [details] [review] [gaia] RickyChien:svoperapps-to-node > mozilla-b2g:master Hey George, could you take a look at this patch? (It has passed my diff-compare) Thanks!
Attachment #8568974 -
Flags: review?(gduan)
|
||
Comment 3•9 years ago
|
||
Code looks good, however 'make TEST_FILES=build/test/integration/distribution_test.js build-test-integration RUN_ON_NODE=1 ' fails ... please try to make it pass.
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8568974 [details] [review] [gaia] RickyChien:svoperapps-to-node > mozilla-b2g:master LGTM, r=gduan, please land it if tbpl and comment 3 pass.
Attachment #8568974 -
Flags: review?(gduan) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
Landed in master: https://github.com/mozilla-b2g/gaia/commit/5a963a91c03f2a110cbb2204b9c8c0f2366e18ef
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•8 years ago
|
Priority: -- → P1
You need to log in
before you can comment on or make changes to this bug.
Description
•