956031 - Ensure geolocation UI automated test checks for presence of geolocation icon in status bar

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)

Description

[Jason Smith [:jsmith]]

Context - bug 955906

Apparently our UI automation didn't catch a regression where the geolocation icon was failing to appear after requesting a location in geolocation. We should enhance the geolocation UI automated test to verify the geolocation icon is present in the status bar.

Comment 1

[Zac C (:zac)]

We can do this.

Comment 2

[[:AndreiH]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15008

Comment 3

[Zac C (:zac)]

Comment on attachment 8355516 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15008

r-,
the bug requests a check of the icon on the permission prompt.

This is the 'target' shaped icon next to the text "Geoloc would like to know your location" on the prompt.

Comment 4

[[:AndreiH]]

That is what I also thought at first, but when I read https://bugzilla.mozilla.org/show_bug.cgi?id=955906#c8, they are referring at the 'target' geolocation icon from the status bar

Comment 5

[Jason Smith [:jsmith]]

(In reply to AndreiH from comment #4)
> That is what I also thought at first, but when I read
> https://bugzilla.mozilla.org/show_bug.cgi?id=955906#c8, they are referring
> at the 'target' geolocation icon from the status bar

Yup, that's right. This is referring to the geolocation icon that appears in the status bar after you allow permissions for geolocation.

Comment 6

[Florin Strugariu [:Bebe]]

Comment on attachment 8355516 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15008

I feel like a simple page object region would be helpful here 
Zac what do you think?

Comment 7

[Zac C (:zac)]

(In reply to Jason Smith [:jsmith] from comment #5)
> (In reply to AndreiH from comment #4)
> > That is what I also thought at first, but when I read
> > https://bugzilla.mozilla.org/show_bug.cgi?id=955906#c8, they are referring
> > at the 'target' geolocation icon from the status bar
> 
> Yup, that's right. This is referring to the geolocation icon that appears in
> the status bar after you allow permissions for geolocation.

My apologies Andrei :)
This makes much more sense!

Comment 8

[Zac C (:zac)]

(In reply to Florin Strugariu [:Bebe] from comment #6)
> Comment on attachment 8355516 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15008
> 
> I feel like a simple page object region would be helpful here 
> Zac what do you think?

Not a page region, a class is too heavy for just one feature.

You can make it a property in the System app as that's where the HTML belongs.

Comment 9

[[:AndreiH]]

Comment on attachment 8355516 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15008

Updated the pull

Comment 10

[Zac C (:zac)]

Comment on attachment 8355516 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15008

r- variable name is wrong.

Comment 11

[[:AndreiH]]

Comment on attachment 8355516 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15008

Updated

Comment 12

[Zac C (:zac)]

Comment on attachment 8355516 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/15008

Looks good my friend!
r+!

Comment 13

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/8ca18c3dcf83bbdbcad203962e39e049baf9a6b8

Comment 14

[Zac C (:zac)]

Jason this has now had the effect of meaning we cannot run this test on CI environments Travis and TBPL because they don't have the Geolocation hardware.

Previously this did run on CI but only tested the presence of the prompt (which was the original regression target).

With this change we can only run it on device now. Is that OK?

Comment 15

[Jason Smith [:jsmith]]

That sounds fine.