Closed Bug 956072 Opened 6 years ago Closed 6 years ago

Distinguish non-writable from non-data properties in type information

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: bhackett, Assigned: bhackett)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Per bug 953024 comment 8 this can help when optimizing accesses on non-writable data properties.
Attachment #8355232 - Flags: review?(jdemooij)
Comment on attachment 8355232 [details] [diff] [review]
patch

Review of attachment 8355232 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8355232 - Flags: review?(jdemooij) → review+
Brian is not available this month and I'd love to have this fixed, so I pushed this to Try:

https://tbpl.mozilla.org/?tree=Try&rev=5093a93d0b37
https://hg.mozilla.org/mozilla-central/rev/48f95993e938
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.