956074 - [B2G][Lockscreen] Unable to pick up or cancel incoming call when the screen is locked

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Natalya Kot [:nkot]]

Description:
The user is unable to pick up or cancel incoming call from the lockscreen, slide buttons are frozen while the call is going through.
 
Repro Steps:
1) Updated Buri to BuildID: 20140102040201
2) Have the screen off on DUT
3) Make a call to the DUT
4) When incoming call goes trough try to slide to the right to answer the call
5) Try to slide to the left to cancel the call

Actual:
Unable to slide right or left, unable to answer or cancel the call

Expected:
Able to slide buttons to answer or cancel the call

Environmental Variables:
Device: Buri M-C Mozilla RIL
BuildID: 20140102040201
Gaia: 67a82f88da231969efa4d22df9fb946abf2cf4df
Gecko: 540d85f60c57
Version: 29.0a1
Firmware Version: V1.2_20131115

Notes: the user is able to answer or cancel incoming call whne device is unlocked

Comment 1

[gbennett]

.:Last Working Build:.
Environmental Variables:
Device: Buri 1.4 mozRIL
BuildID: 20131223040210
Gaia: 5c4bb7e9dcdf6f168701508922c232a67cd8ea1f
Gecko: c0f85061c7d3
Version: 29.0a1
RIL Version: 01.02.00.019.102
Firmware Version: v1.2_20131115

.:First Broken Build:.
Environmental Variables:
Device: Buri 1.4 mozRIL
BuildID: 20131225040201
Gaia: 8f6489ebbb2f869534abd3232095128ce51460a8
Gecko: cd3e9359fd64
Version: 29.0a1
RIL Version: 01.02.00.019.102
Firmware Version: v1.2_20131115

Comment 3

[Jason Smith [:jsmith]]

There's two lockscreen commits in the regression range:

1. https://github.com/mozilla-b2g/gaia/commit/d2764da3dbf0ecea030cfc146d1d45cf661c7f66
2. https://github.com/mozilla-b2g/gaia/commit/a80c0565e54dea3bd547269b0ada349f126f60a5

Comment 4

[Jason Smith [:jsmith]]

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c0f85061c7d3&tochange=cd3e9359fd64

Comment 5

[Jason Smith [:jsmith]]

Can someone get a logcat with this bug?

Comment 6

[Binyamin]

The same regression noticed on Firefox Nightly image for last 2 weeks. Tested on Geeksphone Peak.

Comment 7

[Natalya Kot [:nkot]]

Attachment: logcat

Comment 8

[Jason Smith [:jsmith]]

Steve - this might be a regression from the re-implementation of the locked call screen with canvas. Can you take a look?

Comment 9

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #8)
> Steve - this might be a regression from the re-implementation of the locked
> call screen with canvas. Can you take a look?

Or it could be a regression from bug 933035.

Comment 10

[Steve Chung [:steveck]]

I could not figure out any problem from the log, will take more time to investigate this on Monday, thanks.

Comment 11

[:gerard-majax]

E/GeckoConsole( 6388): [JavaScript Error: "TypeError: this.intentionRouter.unlockingStart is not a function" {file: "app://communications.gaiamobile.org/dialer/gaia_build_defer_oncall.js" line: 256}]
E/GeckoConsole( 6388): [JavaScript Error: "TypeError: this.intentionRouter.unlockingStart is not a function" {file: "app://communications.gaiamobile.org/dialer/gaia_build_defer_oncall.js" line: 256}]

I'm seeing this in my logcat ...

Comment 12

[:gerard-majax]

(In reply to Jason Smith [:jsmith] from comment #3)
> There's two lockscreen commits in the regression range:
> 
> 1.
> https://github.com/mozilla-b2g/gaia/commit/
> d2764da3dbf0ecea030cfc146d1d45cf661c7f66
> 2.
> https://github.com/mozilla-b2g/gaia/commit/
> a80c0565e54dea3bd547269b0ada349f126f60a5

I did try a local revert of https://github.com/mozilla-b2g/gaia/commit/a80c0565e54dea3bd547269b0ada349f126f60a5 and it does NOT fix the issue.

Comment 13

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #12)
> (In reply to Jason Smith [:jsmith] from comment #3)
> > There's two lockscreen commits in the regression range:
> > 
> > 1.
> > https://github.com/mozilla-b2g/gaia/commit/
> > d2764da3dbf0ecea030cfc146d1d45cf661c7f66
> > 2.
> > https://github.com/mozilla-b2g/gaia/commit/
> > a80c0565e54dea3bd547269b0ada349f126f60a5
> 
> I did try a local revert of
> https://github.com/mozilla-b2g/gaia/commit/
> a80c0565e54dea3bd547269b0ada349f126f60a5 and it does NOT fix the issue.

Nor does reverting https://github.com/mozilla-b2g/gaia/commit/d2764da3dbf0ecea030cfc146d1d45cf661c7f66.

However, I do consistently get this when I slide (4 times here) to unlock to answer:
E/GeckoConsole( 7069): [JavaScript Error: "TypeError: this.intentionRouter.unlockingStart is not a function" {file: "app://communications.gaiamobile.org/dialer/gaia_build_defer_oncall.js" line: 256}]
E/GeckoConsole( 7069): [JavaScript Error: "TypeError: this.intentionRouter.unlockingStart is not a function" {file: "app://communications.gaiamobile.org/dialer/gaia_build_defer_oncall.js" line: 256}]
E/GeckoConsole( 7069): [JavaScript Error: "TypeError: this.intentionRouter.unlockingStart is not a function" {file: "app://communications.gaiamobile.org/dialer/gaia_build_defer_oncall.js" line: 256}]
E/GeckoConsole( 7069): [JavaScript Error: "TypeError: this.intentionRouter.unlockingStart is not a function" {file: "app://communications.gaiamobile.org/dialer/gaia_build_defer_oncall.js" line: 256}]

Comment 14

[:gerard-majax]

After removing optimizations: E/GeckoConsole( 7392): [JavaScript Error: "TypeError: this.intentionRouter.unlockingStart is not a function" {file: "app://communications.gaiamobile.org/shared/js/lockscreen_slide.js" line: 446}]

Comment 15

[:gerard-majax]

(In reply to Jason Smith [:jsmith] from comment #9)
> (In reply to Jason Smith [:jsmith] from comment #8)
> > Steve - this might be a regression from the re-implementation of the locked
> > call screen with canvas. Can you take a look?
> 
> Or it could be a regression from bug 933035.

Actually I was wrong, after reverting https://github.com/mozilla-b2g/gaia/commit/a80c0565e54dea3bd547269b0ada349f126f60a5 and reinstalling all Gaia, and not only the system app, it does fix the issue. So this is a regression from bug 933035.

Comment 16

[:gerard-majax]

The issue comes from the IntentionRouter seems to be passed from the Dialer app at https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/call_screen.js#L140:

It has no unlockingStart() nor unlockingStop() method.

Comment 17

[:gerard-majax]

Should the IntentionRouter at https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/call_screen.js#L140 have a unlockingStart() and unlockingStop() method?

Comment 18

[:gerard-majax]

Attachment: Link to Github https://github.com/mozilla-b2g/gaia/pull/15018

Please find attached a pull request that fixes the issue by adding empty unlockingStart() and unlockingStop() methods.

This does not contain any tests, but maybe we need and can write some for this ?

Comment 19

[:gerard-majax]

Of course, I've tested this on my device and now I can unlock the screen when I receive a call.

Comment 20

[Greg Weng [:snowmantw][:gweng][:λ]]

It's a problem that we must defined a general enough version of IR to let both incoming call and normal lockscreen. Steve and I had discussed this before, but there seems left some cases we lost in the progress of development.

The IR is used as a communication way that I want to avoid use a global (hook on the window) and DOM event (dispatchEvent) to do this simple message passing thing (see https://groups.google.com/forum/#!topic/mozilla.dev.gaia/D4kRaSDspQI), especially in this case these intentions really concerns only LockScreen and the slide.

I'll try to solve this problem first, then to see if there is a better way to implement that.

Comment 21

[Etienne Segonzac (:etienne)]

Comment on attachment 8355876 [details] [review]
Link to Github https://github.com/mozilla-b2g/gaia/pull/15018

Ideally I think the shared LockscreenSlide lib should test the existence of those method before calling them (with unit tests).

But let's land this simple and safe patch and file a proper follow up.

Comment 22

[:gerard-majax]

(In reply to Etienne Segonzac (:etienne) from comment #21)
> Comment on attachment 8355876 [details] [review]
> Link to Github https://github.com/mozilla-b2g/gaia/pull/15018
> 
> Ideally I think the shared LockscreenSlide lib should test the existence of
> those method before calling them (with unit tests).
> 
> But let's land this simple and safe patch and file a proper follow up.

Fixed the nit. Filed bug 956662 as followup.

Comment 23

[:gerard-majax]

https://github.com/mozilla-b2g/gaia/commit/728e3dfbe146d54c4bcd4121db373c41dd0b3f1e

Comment 24

[Michael Adeyeye]

Please commit the patch to the github repo. The patch is not yet available on github. This is my git commit info after updating and rebuilding my B2G: 2014-01-06 -7:21:53

Comment 25

[:gerard-majax]

(In reply to Michael Adeyeye from comment #24)
> Please commit the patch to the github repo. The patch is not yet available
> on github. This is my git commit info after updating and rebuilding my B2G:
> 2014-01-06 -7:21:53

It is in the github repo.

Comment 26

[Michael Adeyeye]

Not in https://github.com/mozilla-b2g/B2G, which is the URL always referred to in the MDN.

Source: https://developer.mozilla.org/en-US/Firefox_OS/Preparing_for_your_first_B2G_build

I however saw the update/fix you are referring to in Gaia (https://github.com/mozilla-b2g/gaia).

Comment 27

[Jason Smith [:jsmith]]

(In reply to Michael Adeyeye from comment #26)
> Not in https://github.com/mozilla-b2g/B2G, which is the URL always referred
> to in the MDN.
> 
> Source:
> https://developer.mozilla.org/en-US/Firefox_OS/
> Preparing_for_your_first_B2G_build
> 
> I however saw the update/fix you are referring to in Gaia
> (https://github.com/mozilla-b2g/gaia).

Alexandre did indeed commit this correctly - a patch likes this goes into gaia, not the B2G repository. We've also confirmed on the QA side that this patch indeed works, so the smoketest regression has been fixed.