956113 - Download does not gracefully handle filenames with a colon

Status: NEW

(Firefox :: File Handling, defect)

Description

[Charles Goodwin]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20131205075310

Steps to reproduce:

Firefox 26.0 on Windows 8.1 64bit.

Go here:
http://openclipart.org/detail/177859/fwd-china-door-with-dragon-face-by-rejon-177859

Click 'download'.


Actual results:

I am presented with a 'save as' dialog that presents 'Fwd_' as the filename. If you click on the image instead to open the SVG directly, you'll see the full filename ("Fwd: China door with dragon face.svg") in the url bar.


Expected results:

It should behave the same as the 'save page as' performed on the SVG directly, which is the ':' is replaced with a space.

http://openclipart.org/people/rejon/Fwd:%20China%20door%20with%20dragon%20face.svg
Right click and 'save page as' and it works as desired.

Comment 1

[Alice0775 White]

GET /download/people/rejon/Fwd:%20China%20door%20with%20dragon%20face.svg HTTP/1.1

Response Header
HTTP/1.1 200 OK
Server: Apache/2.2.16 (Debian)
X-Powered-By: PHP/5.3.3-7+squeeze17
Content-Disposition: attachment; filename=Fwd: China door with dragon face.svg
content-transfer-encoding: binary
Expires: 0
Cache-Control: max-age=600, private, must-revalidate
Pragma: public
Content-Type: application/octet-stream
Content-Length: 217467
Accept-Ranges: bytes
Date: Thu, 02 Jan 2014 19:49:05 GMT
X-Varnish: 1490455428 1490294370
Age: 2869
Via: 1.1 varnish
Connection: keep-alive

Comment 2

[Josh Matthews [:jdm]]

Anyone looking at this probably wants to investigate the code that flows through GetFilenameAndExtensionFromChannel (http://mxr.mozilla.org/mozilla-central/source/uriloader/exthandler/nsExternalHelperAppService.cpp#238).