956153 - Remove the inset shadow shown in the message viewer.

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Josiah Bruner [:jsbruner]]

OS X has an inset-like shadow anywhere a message can be read. This doesn't look too pleasant and tends to be distracting. Let's just get rid of it.

Image: http://ge.tt/9UeCY5C1/v/0?c

Comment 1

[Josiah Bruner [:jsbruner]]

Attachment: Patch.

This patch makes such a change.

Richard, could you please review this?

Comment 2

[Josiah Bruner [:jsbruner]]

Oh, I suppose you can't easily test it unless you have OS X, but just take my word that it works. ;)

Comment 3

[Josiah Bruner [:jsbruner]]

Comment on attachment 8355343 [details] [diff] [review]
Patch.

Review of attachment 8355343 [details] [diff] [review]:
-----------------------------------------------------------------

Clearing review flags because the change causes a gap between the message header controls. Will fix that then re-assign flags.

Comment 4

[Josiah Bruner [:jsbruner]]

Attachment: Patch.

This fixes the problem.

Comment 5

[Josiah Bruner [:jsbruner]]

Attachment: Screen shot.

Here's a screenshot showing the change.

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 8355353 [details] [diff] [review]
Patch.

Review of attachment 8355353 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good r+ and ui-r+

Please check my comment if it could center the line better.

::: mail/themes/osx/mail/messageHeader.css
@@ +53,5 @@
>  }
>  
>  #expandedBoxSpacer {
>    display: block;
> +  height: 3px;

I think 5px centers the From line better between the top border and the next line when it is beside of the buttons. But this could only be my font setting on OS X 10.8 (but it should be default).

Comment 7

[Josiah Bruner [:jsbruner]]

Attachment: Patch.

Made the change.

Thanks Richard!

Comment 8

[Nomis101]

Oh, this was the gradient shadow I introduced in Bug 665303. In the older days this looked good, but you are right, that it doesn't anymore.

Comment 9

[Josiah Bruner [:jsbruner]]

https://hg.mozilla.org/comm-central/rev/cd42f16a4f11