Closed Bug 956240 Opened 7 years ago Closed 7 years ago
Mobile Connection: Use webidl event generator for the event that is dispatched by moz Mobile Connection
After moving to use webidl event generator, below interfaces can be removed, - dom/network/interfaces/nsIDOMMozEmergencyCbModeEvent.idl - dom/network/interfaces/nsIDOMMozOtaStatusEvent.idl - dom/network/interfaces/nsIDOMUSSDReceivedEvent.idl - dom/network/interfaces/nsIDOMDataErrorEvent.idl - dom/network/interfaces/nsIDOMCFStateChangeEvent.idl
Comment on attachment 8355451 [details] [diff] [review] Patch, v1 Hi smaug, need your help to review this, thank you.
Attachment #8355451 - Flags: review?(bugs)
Comment on attachment 8355451 [details] [diff] [review] Patch, v1 Great, thanks!
Attachment #8355451 - Flags: review?(bugs) → review+
Full try result: https://tbpl.mozilla.org/?tree=Try&rev=87c8e8491c2c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
So we don't want to condition these on MOZ_B2G_RIL anymore?
(In reply to Peter Van der Beken [:peterv] from comment #7) > So we don't want to condition these on MOZ_B2G_RIL anymore? We condition these on prefs 'dom.mobileconnection.enabled'. And this prefs will be configured based on MOZ_B2G_RIL.
Sure, but that means that we're increasing the binary size with code that's never used (unless dom.mobileconnection.enabled is somehow ever true on non-b2g builds).
You need to log in before you can comment on or make changes to this bug.