956240 - WebMobileConnection: Use webidl event generator for the event that is dispatched by mozMobileConnection

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Edgar Chen [:edgar]]

After moving to use webidl event generator, below interfaces can be removed,
- dom/network/interfaces/nsIDOMMozEmergencyCbModeEvent.idl
- dom/network/interfaces/nsIDOMMozOtaStatusEvent.idl
- dom/network/interfaces/nsIDOMUSSDReceivedEvent.idl
- dom/network/interfaces/nsIDOMDataErrorEvent.idl
- dom/network/interfaces/nsIDOMCFStateChangeEvent.idl

Comment 1

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Comment 2

[Edgar Chen [:edgar]]

Comment on attachment 8355451 [details] [diff] [review]
Patch, v1

Hi smaug, need your help to review this, thank you.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8355451 [details] [diff] [review]
Patch, v1

Great, thanks!

Comment 4

[Edgar Chen [:edgar]]

Full try result: https://tbpl.mozilla.org/?tree=Try&rev=87c8e8491c2c

Comment 5

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/66ffd474bf5b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/66ffd474bf5b

Comment 7

[Peter Van der Beken [:peterv]]

So we don't want to condition these on MOZ_B2G_RIL anymore?

Comment 8

[Edgar Chen [:edgar]]

(In reply to Peter Van der Beken [:peterv] from comment #7)
> So we don't want to condition these on MOZ_B2G_RIL anymore?

We condition these on prefs 'dom.mobileconnection.enabled'.
And this prefs will be configured based on MOZ_B2G_RIL.

Comment 9

[Peter Van der Beken [:peterv]]

Sure, but that means that we're increasing the binary size with code that's never used (unless dom.mobileconnection.enabled is somehow ever true on non-b2g builds).