Closed Bug 956240 Opened 7 years ago Closed 7 years ago

WebMobileConnection: Use webidl event generator for the event that is dispatched by mozMobileConnection

Categories

(Core :: DOM: Events, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(1 file)

After moving to use webidl event generator, below interfaces can be removed,
- dom/network/interfaces/nsIDOMMozEmergencyCbModeEvent.idl
- dom/network/interfaces/nsIDOMMozOtaStatusEvent.idl
- dom/network/interfaces/nsIDOMUSSDReceivedEvent.idl
- dom/network/interfaces/nsIDOMDataErrorEvent.idl
- dom/network/interfaces/nsIDOMCFStateChangeEvent.idl
Attached patch Patch, v1Splinter Review
Comment on attachment 8355451 [details] [diff] [review]
Patch, v1

Hi smaug, need your help to review this, thank you.
Attachment #8355451 - Flags: review?(bugs)
Comment on attachment 8355451 [details] [diff] [review]
Patch, v1

Great, thanks!
Attachment #8355451 - Flags: review?(bugs) → review+
Depends on: 956723
https://hg.mozilla.org/mozilla-central/rev/66ffd474bf5b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
So we don't want to condition these on MOZ_B2G_RIL anymore?
(In reply to Peter Van der Beken [:peterv] from comment #7)
> So we don't want to condition these on MOZ_B2G_RIL anymore?

We condition these on prefs 'dom.mobileconnection.enabled'.
And this prefs will be configured based on MOZ_B2G_RIL.
Sure, but that means that we're increasing the binary size with code that's never used (unless dom.mobileconnection.enabled is somehow ever true on non-b2g builds).
You need to log in before you can comment on or make changes to this bug.