[Bluetooth][cleanup] Reduce warnings and rename g* variables to s* ones

RESOLVED FIXED in 1.3 C2/1.4 S2(17jan)

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ben.tian, Assigned: ben.tian)

Tracking

unspecified
1.3 C2/1.4 S2(17jan)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

TODO:
- rename g* variables to s* ones
- reduce warnings
- remove cancel_discovery() in BluetoothServiceBluedroid::SendFile() as gaia already does it
- remove unused constant DEFAULT_OPP_CHANNEL
Assignee: nobody → btian
Attachment #8355478 - Flags: review?(echou)
Comment on attachment 8355478 [details] [diff] [review]
Patch 1/2 (v1): rename g* variables to s* ones

Review of attachment 8355478 [details] [diff] [review]:
-----------------------------------------------------------------

In fact I'm not 100% sure about how we should name those variables in anonymous namespace. Variables without 'static' keyword in an anonymous namespace may be global(c++03), although you have to do some magic to actually access that variable since it would have a unique name. To be honest I prefer not using any initials such as 'gBluetoothChild' or 'sBluetoothChild'. 'bluetoothChild' in anonymous namespace seems clear enough to me. Nevertheless, this patch makes all this kind of variables have the same naming convention (initial with 's'), I think it's still worth to be merged for making our code more consistent.
Attachment #8355478 - Flags: review?(echou) → review+
Comment on attachment 8355479 [details] [diff] [review]
Patch 2/2 (v1): reduce warnings and remove cancel_discovery() in SendFile()

Review of attachment 8355479 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for cleaning up.
Attachment #8355479 - Flags: review?(echou) → review+
https://hg.mozilla.org/mozilla-central/rev/1b22c75c1046
https://hg.mozilla.org/mozilla-central/rev/615964c59f00
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C2/1.4 S2(17jan)
You need to log in before you can comment on or make changes to this bug.