[Settings] uplift of bug 797661 breaks unit tests

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: julienw, Assigned: kaze)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
cf https://s3.amazonaws.com/archive.travis-ci.org/jobs/15853642/log.txt:

1) [settings] Hotspot Check default hotspot password "before each" hook:
     TypeError: wifiSettingsSection is null
      at initWifiSettingDialog (http://settings.gaiamobile.org:8080/js/hotspot.js:91)
      at hotspot_init (http://settings.gaiamobile.org:8080/js/hotspot.js:9)
      at (anonymous) (http://settings.gaiamobile.org:8080/test/unit/hotspot_test.js:61)
      at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:62)
      at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
      at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973)
      at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984)
      at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932)

Travis job is: https://travis-ci.org/mozilla-b2g/gaia/builds/15853640

This unit test failure makes me afraid that there is an actual bug in the Settings app on v1.2 so I'm asking koi.

I'm assigning to kaze because he's currently investigating whether this is an actual bug or only a unit test issue.
(Reporter)

Comment 1

4 years ago
That said, I don't understand why bug 797661 was uplifted at all, as there is no flag besides tracking-b2g18+.
(Reporter)

Comment 2

4 years ago
Ok, I reverted bug 797661 from v1.2.

Closing then!

Thanks kaze for the help on IRC.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Updated

4 years ago
blocking-b2g: koi? → ---
You need to log in before you can comment on or make changes to this bug.