Closed Bug 956311 Opened 6 years ago Closed 6 years ago

Get rid of nsSVGGeometryFrame

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: longsonr, Assigned: longsonr)

Details

Attachments

(1 file)

Attached patch path.txtSplinter Review
nsSVGGeometryFrame used to be the common base class for nsSVGPathGeometryFrame and nsSVGGlyphFrame. nsSVGGlyphFrame is no more so we might as well fold all the code into nsSVGPathGeometryFrame.
Attachment #8355539 - Attachment is patch: true
Attachment #8355539 - Flags: review?(dholbert)
Assignee: nobody → longsonr
OS: Windows Vista → All
Hardware: x86 → All
Comment on attachment 8355539 [details] [diff] [review]
path.txt

>diff --git a/layout/svg/nsSVGPathGeometryFrame.cpp b/layout/svg/nsSVGPathGeometryFrame.cpp
>--- a/layout/svg/nsSVGPathGeometryFrame.cpp
>+++ b/layout/svg/nsSVGPathGeometryFrame.cpp
> //----------------------------------------------------------------------
> // nsIFrame methods
> 
>+void
>+nsSVGPathGeometryFrame::Init(nsIContent* aContent,
>+                         nsIFrame* aParent,
>+                         nsIFrame* aPrevInFlow)

reindent.

Otherwise, looks good! r=dholbert
Attachment #8355539 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/mozilla-central/rev/eca13ded05d7
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.