956311 - Get rid of nsSVGGeometryFrame

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert Longson [:longsonr]]

Attachment: path.txt

nsSVGGeometryFrame used to be the common base class for nsSVGPathGeometryFrame and nsSVGGlyphFrame. nsSVGGlyphFrame is no more so we might as well fold all the code into nsSVGPathGeometryFrame.

Comment 1

[Daniel Holbert [:dholbert]]

Comment on attachment 8355539 [details] [diff] [review]
path.txt

>diff --git a/layout/svg/nsSVGPathGeometryFrame.cpp b/layout/svg/nsSVGPathGeometryFrame.cpp
>--- a/layout/svg/nsSVGPathGeometryFrame.cpp
>+++ b/layout/svg/nsSVGPathGeometryFrame.cpp
> //----------------------------------------------------------------------
> // nsIFrame methods
> 
>+void
>+nsSVGPathGeometryFrame::Init(nsIContent* aContent,
>+                         nsIFrame* aParent,
>+                         nsIFrame* aPrevInFlow)

reindent.

Otherwise, looks good! r=dholbert

Comment 2

[Robert Longson [:longsonr]]

https://tbpl.mozilla.org/?tree=Try&rev=3c26b9ac3860

Comment 3

[Robert Longson [:longsonr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eca13ded05d7

Comment 4

[Robert Longson [:longsonr]]

Prior try run... https://tbpl.mozilla.org/?tree=Try&rev=56902f86062b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eca13ded05d7