HTTP cache v2: fix CacheIOThread::Target() wait conditioning

RESOLVED FIXED in mozilla29

Status

()

Core
Networking: Cache
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mayhemer, Assigned: mayhemer)

Tracking

unspecified
mozilla29
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8355608 [details] [diff] [review]
v1

There is a rare race condition in CacheIOThread::Target().  It might happen that early after startup the caller of that method may get the target XPCOM thread sooner then the observer on it is correctly set-up.  Missing observer may cause we don't catch dispatch of an xpcom event.  This is probably not causing any serious problems, since xpcom events will be handled anyway later or sooner on.  But for correctness this should be fixed.
Attachment #8355608 - Flags: review?(michal.novotny)
(Assignee)

Updated

4 years ago
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Attachment #8355608 - Flags: review?(michal.novotny) → review+
https://hg.mozilla.org/mozilla-central/rev/f7fb8188c0ef
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.