Closed Bug 956374 Opened 10 years ago Closed 10 years ago

HTTP cache v2: fix CacheIOThread::Target() wait conditioning

Categories

(Core :: Networking: Cache, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: mayhemer, Assigned: mayhemer)

References

Details

Attachments

(1 file)

Attached patch v1Splinter Review
There is a rare race condition in CacheIOThread::Target().  It might happen that early after startup the caller of that method may get the target XPCOM thread sooner then the observer on it is correctly set-up.  Missing observer may cause we don't catch dispatch of an xpcom event.  This is probably not causing any serious problems, since xpcom events will be handled anyway later or sooner on.  But for correctness this should be fixed.
Attachment #8355608 - Flags: review?(michal.novotny)
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Attachment #8355608 - Flags: review?(michal.novotny) → review+
https://hg.mozilla.org/mozilla-central/rev/f7fb8188c0ef
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: