Open Bug 956390 Opened 6 years ago Updated 2 months ago

Add suggested reviewers capability to the ui review flag

Categories

(bugzilla.mozilla.org :: Extensions, enhancement, P3)

Production
enhancement

Tracking

()

ASSIGNED

People

(Reporter: jsmith, Assigned: dkl)

Details

(Keywords: bmo-big)

Add suggested reviewers to the ui review flag to suggest UX designers that could help review a patch for UX quality.
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Questions:

1. Should we track the ui-review suggested reviewers separately from the standard review flag list of users or just re-use the same group of people?
2. Also do you think it would be useful from a reporting point of view to differentiate between the number of review requests and ui-review requests when showing the number next to the suggested reviewers name?
Flags: needinfo?(jsmith)
(In reply to David Lawrence [:dkl] from comment #1)
> Questions:
> 
> 1. Should we track the ui-review suggested reviewers separately from the
> standard review flag list of users or just re-use the same group of people?

Separately as a different group of people. The UX reviewers are going to be different than the code reviewers.

> 2. Also do you think it would be useful from a reporting point of view to
> differentiate between the number of review requests and ui-review requests
> when showing the number next to the suggested reviewers name?

I don't think so - the people doing UX reviews are a different group of people than the code reviewers.
Flags: needinfo?(jsmith)
Yes, Jason is correct. What I'd like to do is have everyone continue to use (flag) the general UX alias: firefoxos-ux-bugzilla@mozilla.com. This alias can be used for review? and needinfo?. Then, as we currently do, we'll triage and assign bugs out of that list to the right people to review twice daily. 

This way, people are only required to remember a single Bugzilla identity, and things won't get lost as we shift resources around on to different things (which we've been doing quarterly over the past year).
Flags: needinfo?(firefoxos-ux-bugzilla)
Flags: needinfo?(firefoxos-ux-bugzilla)
Keywords: bmo-big
Priority: -- → P3
We are investigating the work it would take to implement this as it is not trivial. We will need to refactor some of the DB schema and extension code to allow for suggested reviewers per flag in a generic way as we currently only look at the 'review' flag. Just as a time estimate, it may be 2-3 weeks before we can start as we have a few quarterly goals that will need to be completed first.

An overview of what we are working on currently:
https://wiki.mozilla.org/BMO

Thanks
dkl
Type: defect → enhancement
Component: Extensions: Review → Extensions
You need to log in before you can comment on or make changes to this bug.