956392 - Fix validation errors on https://www.mozilla.org/en-US/firefox/new/

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[George Vidalakis]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20140103004002

Steps to reproduce:

I tried to validate https://www.mozilla.org/en-US/firefox/new/ with W3C HTML Validator ( http://validator.w3.org/ ).


Actual results:

I saw at the errors list that there is an "a" tag whose "href" attribute contain the & sybmol (line 242) three times.


Expected results:

The & symbol should be replaced with & .

Comment 1

[Kohei Yoshino [:kohei]]

I believe this query string (?esab=a&s=silent+download&r=0&as=s) was automatically appended to the URL when the page author (or someone) searched the article on SUMO. So it's not necessary.

Actually I have omitted the query string from the same link in Tabzilla's Update Bar (Bug 935719).

I'll send a PR to remove it.

Comment 2

[Kohei Yoshino [:kohei]]

Attachment: Pull Request on GitHub

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/fee6d65c6a83c6ca8b3a7c9a765616054f3faa74
Bug 956392 - escape ampersands in links

https://github.com/mozilla/bedrock/commit/06f705132b6e246e9512d5f47857579544ecf820
Merge pull request #1560 from kyoshino/bug-956392-escape-ampersands

Bug 956392: Escape ampersands in links