956421 - JavaScript error: airplane_mode.js, line 157: window.navigator.mozMobileConnections is undefined

Status: RESOLVED DUPLICATE of bug 951888

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Gregor Wagner [:gwagner]]

This happens during gaia unit tests:

https://tbpl.mozilla.org/php/getParsedLog.php?id=32530548&tree=B2g-Inbound&full=1

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

This affects B2G Desktop 1.3 mozilla-aurora and 1.4 mozilla-central (master).

Tested with:

http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/2014/01/2014-01-10-04-02-06-mozilla-central/b2g-29.0a1.multi.mac64.dmg

(One can see this on startup)

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

A similar issue might be affecting integration tests in travis:
https://travis-ci.org/mozilla-b2g/gaia/jobs/16968003

1) Notification.get(): promise is fulfilled:
  JavaScriptError: (17) TypeError: mobileConnections is undefined

  Remote Stack:
  @app://system.gaiamobile.org/js/airplane_mode.js, line 282 ...

In any case, I think the problem arises when we build a profile without the desktop shims. airplane_mode.js depends on navigator.mozMobileConnections to be a thing, which I don't think we should rely on.

Gregor, perhaps this bug should be moved to the System component, since it is really just a javascript issue.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

We need navigator.mozMobileConnections for enabling/disabling airplane mode as it has the setRadioEnabled API.

The line was added in the pull request[1] and it passed all tests on travis. Michael, Any ideas on why it passed travis tests but failed on TBPL? If we should add shims of navigator.mozMobileConnections, any recommended ways of doing it?

[1]: https://travis-ci.org/mozilla-b2g/gaia/builds/15505783

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Clear ni?. We found that the tests were disabled on gaia master and that's why it passed all tests on travis. Instead of adding shims for B2G desktop, I will add a check on the mozMobileConnections API.

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Arthur Chen [:arthurcc] from comment #4)
> Clear ni?. We found that the tests were disabled on gaia master and that's
> why it passed all tests on travis. Instead of adding shims for B2G desktop,
> I will add a check on the mozMobileConnections API.

Thank you! Yeah, I guess we never use the desktop shims during integration tests in travis, so we unfortunately have to check manually for the existence of the API.