956424 - [B2G][Settings][SIM Security] SIM Security enabled/disabled information in "Settings" shows wrong information

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[sarsenyev]

Description:
When changing SIM Security status, the SIM Security settings info, shows the previous old state

Repro Steps:
1) Updated Buri to BuildID: 20140103004001
2) Go to "Settings" from the home screen
3) Navigate into "SIM Security", make sure it's disabled by default and the settings shows "disabled"
4) "Enter "SIM Security" PIN number
5) Go back to the "Settings" menu

Actual:
Even when the security PIN is enabled the settings shows still "Disabled" state,

Expected:
When the SIM PIN is enabled the settings info shows "Enabled"
When the SIM PIN is disabled the settings info shows "Disabled"

Environmental Variables:
Device: Buri 1.3 COM
BuildID: 20140103004001
Gaia: ae7d05689b6b9ac4ec6182217dfdef06be28e886
Gecko: d9226a660d52
Version: 28.0a2
RIL Version: 01.02.00.019.102
Firmware Version: v1.2_20131115

Notes:
Repro frequency: 100%
See attached: video clip

Comment 1

[Jason Smith [:jsmith]]

Does this reproduce on 1.2?

Comment 2

[Montoya Clemmons (MClemmons)]

In response to comment 1  Jason Smith [:jsmith]
Does this reproduce on 1.2?

The issue does not reproduce on 1.2
When following the Steps to reproduce in Comment 0 on 1.2, When the SIM PIN is enabled the settings info shows "Enabled" When the SIM PIN is disabled the settings info shows "Disabled"

Below are Environmental Variables:
Device: buri 1.2 MOZ
BuildID: 20140103004001
Gaia: 2b116456d8a3ed3e9741b370d628f225c58587da
Gecko: 9cbbf14a0f69
Version: 26.0
RIL Version: 01.01.00.019.281

Comment 3

[Montoya Clemmons (MClemmons)]

Regression Window:

Last working build (Does not Reproduce):

Environmental Variables:
Device: buri 1.3 MOZ
BuildID: 20131114143149
Gaia: 4ea5adac92d6a9ab035e708e941d50be0d670da2
Gecko: 7b014f0f3b03
Version: 28.0a1
RIL Version: 01.02.00.019.106


First broken (Reproduces):

Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20131115040200
Gaia: ac42cb33f21b3f13595432c965f44615daae2225
Gecko: b2fab608772f
Version: 28.0a1
RIL Version: 01.02.00.019.106

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: regression.

Author, EJ, please re-distribute the bug.

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Took this bug!

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on github

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8359569 [details] [review]
patch on github

Arthur, please help me review this small patch when you have time ! 

BTW, I already made Travis green, thanks :)

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8359569 [details] [review]
patch on github

Please check my github comments, thnaks!

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8359569 [details] [review]
patch on github

Hi Arthur,

just update based on your comments on Github. Please help me review it when you have time ! Thanks :)

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8359569 [details] [review]
patch on github

It seems that we need to mock the localize function to fix the tests.

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8359569 [details] [review]
patch on github

Added missing mock and Travis is green now ! 

Thanks Arthur :)

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8359569 [details] [review]
patch on github

r=me. Thanks!

Comment 13

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, patched were landed on : 

Gaia/master : f8b6f5200800662089ffa97eb2d4c89ffc4e9263
Gaia/v1.3 : 423326d524d3807b3a7ef9cc10f34baf26a34b8c

:)