Closed Bug 956426 Opened 10 years ago Closed 10 years ago

missing : after property id handlers.js:61

Categories

(Testing Graveyard :: Mozmill, defect)

Product:
Testing Graveyard
Component:
Mozmill
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Keywords: regression, Whiteboard: [mozmill-2.0.4+])

Attachments

(2 files)

Patch v1
1.03 KB, patch
cmtalbert
: review+
Details | Diff | Splinter Review
Follow-up v1
1.14 KB, patch
davehunt
: review+
Details | Diff | Splinter Review 
As seen on bug 956315 we fail to create the Mozmill handler because of a broken ConsoleObserver declaration:

[Exception... "'Error: Socket failed to bind, kill all firefox processes' when calling method: [nsIObserver::observe]"  nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: no]
missing : after property id handlers.js:61

While creating services from category 'profile-after-change', could not create service for entry 'MozmillHandlers', contract ID '@mozilla.org/mozmill/handlers;1'

Not sure why I haven't seen this before when I was working on bug 897414, but this breaks indeed our error handling in failure cases. I will have a fix shortly.
Whiteboard: [mozmill-2.0.4+]
Attached patch Patch v1 — — Splinter Review 

        Attachment #8355676 -
        Flags: review?(ctalbert)

    
    

    
  
Comment on attachment 8355676 [details] [diff] [review]
Patch v1

Review of attachment 8355676 [details] [diff] [review]:
-----------------------------------------------------------------

wonder how we missed this one in the first place. :-(

        Attachment #8355676 -
        Flags: review?(ctalbert) → review+

    
    

    
  
Patch landed as:
https://github.com/mozilla/mozmill/commit/738c5abdb294381aeadaa36f4ddc813276c44104 (master)
https://github.com/mozilla/mozmill/commit/2e0811f045712be263675c4a679e454260ca1da4 (hotfix-2.0)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
This was actually not the right fix. Now both properties are undefined. I will have to check that again why I see those messages on OS X.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Follow-up v1
        — 
          — Splinter Review
      

    


  
I can't believe how silly this is. Now I have to fix a fix for a fix. I'm very sorry about that.

        Attachment #8357801 -
        Flags: review?(dave.hunt)

        Attachment #8357801 -
        Flags: review?(ctalbert)

        Attachment #8357801 -
        Flags: review?(dave.hunt) → review+

        Attachment #8357801 -
        Flags: review?(ctalbert)

    
    

    
  
Landed follow-up patch as:
https://github.com/mozilla/mozmill/commit/d9100a5dd0bcc756543f510b3d0bd251904f2897 (master)
https://github.com/mozilla/mozmill/commit/4d9d3ce00b2bd29a329cf1494d49bde0c203eb43 (hotfix-2.0)
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Depends on: 964318
Product: Testing → Testing Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: