956428 - JavaScript Error: "conn.getPreferredNetworkType is not a function"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

JavaScript error: http://system.gaiamobile.org:8080/js/emergency_callback_manager.js, line 191: conn.getPreferredNetworkType is not a function

Not sure if this is likely to be related to:

https://github.com/mozilla-b2g/gaia/blob/f55764b3cfb5937e8ca58835342a67059cd3ad8f/apps/system/js/emergency_callback_manager.js#L191

The line was merged in https://github.com/mozilla-b2g/gaia/commit/3508d5c030f3c3474a6566140aa663d07801d333#diff-bdc40303b623075bfb9cb8f7074db7c8R191 so cc'ing :jaoo and setting needinfo.

I found this from poking around marifuzz by starting B2G Desktop from rev 4ecd4f2ba149 with Gaia profile rev f55764b.

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

So, is this happening in B2G desktop builds?

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #1)
> So, is this happening in B2G desktop builds?

Yes. See comment 0:

(In reply to Gary Kwong [:gkw] [:nth10sd] from comment #0)
> I found this from poking around marifuzz by starting B2G Desktop from rev
> 4ecd4f2ba149 with Gaia profile rev f55764b.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/15351

Jose, could you help review the change? Thanks!

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8360321 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/15351

This issue happens on desktop builds. I've noticed Kevin added a fix in bug 959107 so there wouldn't be necessary this change, am I right?

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #4)
> Comment on attachment 8360321 [details]
> Link to https://github.com/mozilla-b2g/gaia/pull/15351
> 
> This issue happens on desktop builds. I've noticed Kevin added a fix in bug
> 959107 so there wouldn't be necessary this change, am I right?

Oops, sorry I meant bug 956012.

As this bug could be fixed by that bug It would be great to check whether it is still happening. Gary, could you give it a try please? Thanks.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8360321 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/15351

It is still better to check the existence of the APIs in case the code is running on environments without them.

Comment 7

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

> As this bug could be fixed by that bug It would be great to check whether it
> is still happening. Gary, could you give it a try please? Thanks.

I'd prefer that the fix (comment 6) be verified later after it has landed.

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8360321 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/15351

LGTM. Thanks Arthur.

r=me

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks Jose!

master: d82724dde400928ad889084c9d9571f6861d8ffe