Open
Bug 956474
Opened 10 years ago
Updated 2 years ago
ManifestDestiny parser doesn't fail on unknown conditions
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
REOPENED
People
(Reporter: Ms2ger, Unassigned)
References
Details
Attachments
(2 files)
3.91 KB,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
1.41 KB,
patch
|
mdas
:
review+
|
Details | Diff | Splinter Review |
This wasted me quite some time earlier.
Attachment #8355756 -
Flags: review?(wlachance)
Comment 1•10 years ago
|
||
Comment on attachment 8355756 [details] [diff] [review] Patch v1 Review of attachment 8355756 [details] [diff] [review]: ----------------------------------------------------------------- Seems like a good idea to me. I can see how the old behaviour caused problems. I guess we'll need to be careful landing this to make sure stuff doesn't break though? Would be good to see a try run on this.
Attachment #8355756 -
Flags: review?(wlachance) → review+
Reporter | ||
Comment 2•10 years ago
|
||
Indeed. Try is looking good, though.
Reporter | ||
Comment 4•10 years ago
|
||
For failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=33227487&tree=Try
Attachment #8362189 -
Flags: review?(mdas)
Flags: needinfo?(Ms2ger)
Comment 5•10 years ago
|
||
Comment on attachment 8362189 [details] [diff] [review] Fix Gu (untested) Review of attachment 8362189 [details] [diff] [review]: ----------------------------------------------------------------- lgtm, thanks!
Attachment #8362189 -
Flags: review?(mdas) → review+
Reporter | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/afaeb5adc044
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Reporter | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0467b6d6d43a
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla30 → ---
Comment 8•10 years ago
|
||
This needs to land in github as well, else the changes will get overwritten when we do the final merge (bug 949600). When this finally lands, please needinfo either me or :ahal and we can do that.
Comment 9•10 years ago
|
||
Merge of backout: https://hg.mozilla.org/mozilla-central/rev/0467b6d6d43a
Comment 10•10 years ago
|
||
why was this backed out? is there more work to do on this bug? do we need to land on github?
Reporter | ||
Comment 11•10 years ago
|
||
It was backed out for bug 970455; there may have been more, similar cases. I don't have time to track those down right now.
Assignee: Ms2ger → nobody
Comment 12•10 years ago
|
||
(In reply to Joel Maher (:jmaher) from comment #10) > why was this backed out? is there more work to do on this bug? do we need > to land on github? No need to land on github. That repo is dead.
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•