95659 - memory leak in prustack.c

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P2)

Description

[Jeff Hostetler]

the static variable _pr_stackLock is leaked.

consider adding the following function to 
nsprpub/pr/src/threads/combined/prustack.c and
calling it from PR_Cleanup() (see the "XXX: ..."
comment near the bottom).

#if 1//begin JLH added ()
void _PR_CleanupStacks(void)
{
	if (!_pr_stackLock)
		return;

	PR_DestroyLock(_pr_stackLock);
	_pr_stackLock = NULL;
}
#endif//end JLH added ()

Comment 1

[Keyser Sose]

You should really start using the cvs diff -u command and attach that so it can
go straight into the tree (if you need help learning about it just email me
[e-mail])

Comment 2

[Wan-Teh Chang]

Attachment: Proposed patch, based on the suggestion of [e-mail].

Comment 3

[Wan-Teh Chang]

Fix checked in on the tip of NSPR.