9566 - Scrolling up in bookmarks is doing horrible things

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[David Hyatt]

Something is screwy in my logic for backwards scrolling when the items are
indented more than one level.  This is making bookmarks and other tree views
create duplicate rows when you start scrolling up.

Marking as M8.

Comment 1

[David Hyatt]

*** Bug 9525 has been marked as a duplicate of this bug. ***

Comment 2

[David Hyatt]

*** Bug 9525 has been marked as a duplicate of this bug. ***

Comment 3

[David Hyatt]

Nailed it with a fix checked in about 1:18am on July 10.

Comment 4

[ckritzer (gone)]

For 1999071408 build:
	-MacOS:  can't launch Bookmarks window from menu
	-Win95:	there are no bookmarks in bookmark page & you can't add any
	-Linux6:	having weird problems-investigating if it is my machine or the
build...

Comment 5

[ckritzer (gone)]

WinNT 1999073011 build = verified fixed.  Checking other platforms...

Comment 6

[ckritzer (gone)]

Verified fixed on:
1999082412 WinNT BUT no scroll bars on 1999082408 Linux6 and 1999082410 MacOS86
bookmarks window doesn't load at all.  Reopening bug.

Comment 7

[leger]

Clearing FIXED resolution due to reopen.

Comment 8

[David Hyatt]

The lack of scrollbars is actually caused by the bug "tables ignore
mComputedWidth and mComputedHeight", which is also assigned to me.  You should
close this out and maybe add a comment to the other one that the bookmarks
scrolling problem is caused by that.

Comment 9

[leger]

Would like moved to M10 whilst bug is resolved.  Not an M9 blocker.  Or whatever
trudelle would like to do.

ckritzer, if this happens with M9 candidate build and you feel a Release Note is
needed. Please do so at:
http://bugzilla.mozilla.org/show_bug.cgi?id=11352

Comment 10

[ckritzer (gone)]

Actually, the Linux m9 candidate (apprunner) wouldn't launch because of a
missing file.  No way to verify this until I have a working m9 linux candidate.
The Linux build used (99082408) was the m10 build.  The WinNT & MacOS builds
were m9 candidates.  The upshot of all this is that the bug cannot be regressed
until a) the other bug David was talking about is fixed and b) we get a working
m9 build, if that is *the* build to regress against.  If you prefer to push
this off until m10, that's fine with me.

Comment 11

[Peter Trudelle]

Moving to m10

Comment 12

[David Hyatt]

This particular bug was fixed. Note that there is a general crash caused by
moving up rapidly, but that's not what this bug was originally about.  I already
have an open bug on the "Moving the thumb rapidly" problem, so I'm closing this
one.

Comment 13

[ckritzer (gone)]

Closed per engineer's comments

Comment 14

[leger]

BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.