956619 - [keyboard] should use |hideKeyboardImmediately| instead of |frame.hidden = true| while |launchOnly| is true

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Should use |hideKeyboardImmediately| instead of  |frame.hidden = true| while |launchOnly| is true.

Comment 1

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

(In reply to GaryChen [:GaryChen][:PYChen] from comment #0)
> Should use |hideKeyboardImmediately| instead of  |frame.hidden = true| while
> |launchOnly| is true.

If we only set showing frame hidden will mess keyboard frame status up then KM handles OOM event incorrect.

Comment 2

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/15023

Hi Tim,
   Please help to review this patch, thanks.

Comment 3

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Comment on attachment 8355971 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/15023

Hi Tim,
   I've addressed your comment, please help to review this patch again.
   Thanks~

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8355971 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/15023

It would be better if we could re-distribute the responsibility of each functions in the future.

Thanks.

Comment 5

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/16449744

landed in gaia master:
https://github.com/mpizza/gaia/commit/27c207c1d6621a250a1ddc2e0b4cff8160867d58