[keyboard] should use |hideKeyboardImmediately| instead of |frame.hidden = true| while |launchOnly| is true

RESOLVED FIXED

Status

Firefox OS
Gaia::System::Input Mgmt
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: GaryChen, Assigned: GaryChen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Should use |hideKeyboardImmediately| instead of  |frame.hidden = true| while |launchOnly| is true.
Assignee: nobody → gchen
(In reply to GaryChen [:GaryChen][:PYChen] from comment #0)
> Should use |hideKeyboardImmediately| instead of  |frame.hidden = true| while
> |launchOnly| is true.

If we only set showing frame hidden will mess keyboard frame status up then KM handles OOM event incorrect.
Created attachment 8355971 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/15023

Hi Tim,
   Please help to review this patch, thanks.
Attachment #8355971 - Flags: review?(timdream)
Attachment #8355971 - Flags: review?(timdream) → feedback+
Comment on attachment 8355971 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/15023

Hi Tim,
   I've addressed your comment, please help to review this patch again.
   Thanks~
Attachment #8355971 - Flags: review?(timdream)
Comment on attachment 8355971 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/15023

It would be better if we could re-distribute the responsibility of each functions in the future.

Thanks.
Attachment #8355971 - Flags: review?(timdream) → review+
travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/16449744

landed in gaia master:
https://github.com/mpizza/gaia/commit/27c207c1d6621a250a1ddc2e0b4cff8160867d58
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.