95668 - memory leak in pruthr.c

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P2)

Description

[Jeff Hostetler]

there are a bunch of static variables that are initialized
in _PR_InitThreads() that are never freed/destroyed.

consider adding the following to 
nsprpub/pr/src/threads/combined/pruthr.c and calling it 
from PR_Cleanup() (see the "XXX: ..." comment near the bottom).


#if 1//begin JLH added ()
void _PR_CleanupThreads(void)
{
	if (_pr_terminationCVLock)
	{
		PR_DestroyLock(_pr_terminationCVLock);
		_pr_terminationCVLock = NULL;
	}
	if (_pr_activeLock)
	{
		PR_DestroyLock(_pr_activeLock);
		_pr_activeLock = NULL;
	}
	if (_pr_primordialExitCVar)
	{
		PR_DestroyCondVar(_pr_primordialExitCVar);
		_pr_primordialExitCVar = NULL;
	}
	if (_pr_deadQLock)
	{
		PR_DestroyLock(_pr_deadQLock);
		_pr_deadQLock = NULL;
	}
	// TODO see if _pr_dead{Native,User}Q need to be deleted
}
#endif//end JLH added ()

Comment 1

[Keyser Sose]

Dude you kick ass :) Nuff said :)

Comment 2

[Wan-Teh Chang]

Attachment: Proposed patch, based on the suggestion of [e-mail].

Comment 3

[Wan-Teh Chang]

Fix checked in on the tip of NSPR.