Closed Bug 956715 Opened 10 years ago Closed 10 years ago

histogram_tools.py no longer compatible with older versions of Histograms.json

Categories

(Toolkit :: Telemetry, defect)

Product:
Toolkit
Component:
Telemetry
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla29

People

(Reporter: mreid, Assigned: rvitillo)

Details

Attachments

(1 file, 1 obsolete file)

956715
1.20 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
Loading a version of Histograms.json prior to the changes landed in bug 742500 throws a KeyError from the `check_expiration` method.

The Telemetry server code uses histogram_tools.py to parse and validate histogram data for arbitrary versions of Histograms.json, so we need to be able to handle cases both with and without the expiration info.

It's a single-line change to fix, see attached patch.
Attachment #8356107 - Flags: review?(rvitillo)
Attachment #8356107 - Flags: review?(rvitillo) → review+
Roberto, could you check this in for me?  I'm not currently set up to build / push to try / etc.
Flags: needinfo?(rvitillo)
Attached patch 956715 — — Splinter Review 

        Attachment #8356107 -
        Attachment is obsolete: true

        Attachment #8356531 -
        Flags: review+
Flags: needinfo?(rvitillo)

        Attachment #8356531 -
        Flags: review+ → review?(vdjeric)

        Attachment #8356531 -
        Flags: review?(vdjeric) → review+
Assignee: nobody → rvitillo

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/b8816fd8a5a1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla29

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: