956741 - Load first run on start page for the first 3 tabs

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Firefox Start, defect, P2)

Description

[Rodrigo Silveira [:rsilveira] [:rodms]]

After discussion on bug 951818 we're making the start page load on the first 3 times the start page is loaded for v1. A long term solution will require l10 and be handled in v2 on bug 951818.
p=1

Comment 1

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v1

Using a pref to keep track of count, don't need the firstrun code in BrowserCLH anymore.

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 8358066 [details] [diff] [review]
Patch v1

Review of attachment 8358066 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/tests/mochitest/head.js
@@ +21,5 @@
>  /*=============================================================================
> +  Test prefs
> +=============================================================================*/
> +
> +Services.prefs.setIntPref("browser.firstrun.count", 0);

Another way to do this is here:
http://dxr.mozilla.org/mozilla-central/source/testing/profiles/prefs_general.js

That might be a good idea since it will also be used by any metro tests added in other directories in the future.

Comment 3

[Rodrigo Silveira [:rsilveira] [:rodms]]

Cool, didn't know about that prefs file. Made the change and landed:
https://hg.mozilla.org/integration/fx-team/rev/949aaa3b5b8f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/949aaa3b5b8f

Comment 5

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v2

Patch that landed - with review comment addressed.

Comment 6

[Rodrigo Silveira [:rsilveira] [:rodms]]

Comment on attachment 8360046 [details] [diff] [review]
Patch v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): None.
User impact if declined: First run experience will go away too quickly.
Testing completed (on m-c, etc.): On m-c since 2014-01-13
Risk to taking this patch (and alternatives if risky): Very low, metro change only.
String or IDL/UUID changes made by this patch: None.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/701137e8b96b

Comment 8

[u279076]

Does this have in-testsuite tests?

Comment 9

[Rodrigo Silveira [:rsilveira] [:rodms]]

No. It does change a pref to not load the feature in tests though.

Comment 10

[Matt Brubeck (:mbrubeck)]

I believe we'll have mozmill running Metro Firefox soon.  This might be a good case for a mozmill test.

Comment 11

[u279076]

in-qa-testsuite? as per comment 10.

Comment 12

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 6.3; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0

Verified as fixed on latest Aurora (build ID: 20140122004004) and latest Nightly (build ID: 20140122030521).

Comment 13

[Mihaela Velimiroviciu (:mihaelav)]

Setting in-testsuite- and in-qa-testsuite- since we don't support Metro anymore