95677 - update urltest.cpp

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Andreas Otte]

urltest needs an overhaul ...

Comment 1

[Andreas Otte]

urltest.cpp should be updated to the latest changes in urlparsing. Also some
more tests should be added.

Comment 2

[Andreas Otte]

Attachment: patch to bring urltest uptodate

Comment 3

[Andreas Otte]

Attachment: Additional file with windows parsing examples

Comment 4

[Andreas Otte]

I changed the format of urlparse.dat to include the testurl and the expected
results with -std and without.

Also urlparse.dat contains some more tests, especially file url tests, but they
are only for a unix like OS.

For that reason there is now a urlparse_win.dat which gets installed for
windows, which also contains some windows specific file url tests.

Maybe someone can do a mac version?

Comment 5

[benc]

I think bbaetz is assigned this in our QA group, for the dozen or so business
days he is remaining here. I expect I will take this over when he leaves b/c get
the URL releated stuff as blackbox tester.

Comment 6

[Bradley Baetz (:bbaetz)]

I haven't been working on the url parser...

Comment 7

[Andreas Otte]

You can check on the options of urltest and see if it fits your criteria. Some
examples:

urltest -std -file urltest.dat

checks the testcases in the file with calling the nsStdURLParser


urltest -file urlparse.dat
checks the testcases in the file while really creating the URIs, sometimes using
different urlparsers.


urltest -abs x

x is irrelevant, as long as there is no base url the internal relative urls
tests are executed
urltest http://foo/bar 

parses the absolute url into its components

urltest http://foo/bar -abs bar2

Resolves the base url and the relative path to a new url.

Comment 8

[Andreas Otte]

Attachment: another updated version of urltest.cpp

Comment 9

[Andreas Otte]

This version works with urltest -abs without parameter and executes the relative
url test. It also counts the failed relative tests and returns a correct error
code for all tests so that it can be used in shell scripts to check the result
of the tests.

 

Comment 10

[Andreas Otte]

Attachment: better version

Comment 11

[Andreas Otte]

For the new version I included the base url into the array of relative url tests
which now allows different base urls. Added a test to check parsing of params
inside directory.

Comment 12

[Andreas Otte]

Attachment: updated patch

Comment 13

[Andreas Otte]

Attachment: file urls testfile for unix

Comment 14

[Andreas Otte]

Attachment: file url testfile for windows

Comment 15

[Andreas Otte]

The last three attachments contain the whole update to urltest. Now there is
urlparse.dat for generic urls and urlparse_unx.dat and urltest_win.dat for
unix/windows specific file urls. Mac stuff still missing.

Comment 16

[Doug Turner (:dougt)]

looks fine.  I assume that you tested it and stuff. r=me.

darin can you sr.

Comment 17

[Andreas Otte]

Yes I did some tests :-), it's in my tree for months now. I just didn't like it
anymore to discuss with people output of urltest which nobody could verify or
reproduce. I will ask Conrad for a file with mac file urls. I the future we
might have to change some of the test urls, that depends on where we go with UNC
support.

Comment 18

[Darin Fisher]

Comment on attachment 48617 [details] [diff] [review]
updated patch

sr=darin

Comment 19

[Andreas Otte]

checked in

Comment 20

[Andreas Otte]

closing bug ...