Closed Bug 956783 Opened 6 years ago Closed 6 years ago

Stop using NULL in Fennec's JNI code

Categories

(Firefox for Android :: General, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 29

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file)

No description provided.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #8356179 - Flags: review?(nchen)
Comment on attachment 8356179 [details] [diff] [review]
Patch (v1)

Review of attachment 8356179 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks!
Attachment #8356179 - Flags: review?(nchen) → review+
Hmm, I got this in my local build:

24:12.46 *** Error: The generated JNI code has changed. Please run cp /media/storage/moz/mozilla-central/objdir-android/mobile/android/base/jni-stubs.inc /media/storage/moz/mozilla-central/mozglue/android && cp /media/storage/moz/mozilla-central/objdir-android/mobile/android/base/GeneratedJNIWrappers.* /media/storage/moz/mozilla-central/widget/android and repeat the build.

What gives?
Flags: needinfo?(nchen)
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #3)
> Hmm, I got this in my local build:
> 
> 24:12.46 *** Error: The generated JNI code has changed. Please run cp
> /media/storage/moz/mozilla-central/objdir-android/mobile/android/base/jni-
> stubs.inc /media/storage/moz/mozilla-central/mozglue/android && cp
> /media/storage/moz/mozilla-central/objdir-android/mobile/android/base/
> GeneratedJNIWrappers.* /media/storage/moz/mozilla-central/widget/android and
> repeat the build.
> 
> What gives?

Ah, you should run those commands and commit any resulting changes. The generated JNI code is actually part of the tree, so when the generated code changes, the changes have to be copied back to the tree and committed.
Flags: needinfo?(nchen)
https://hg.mozilla.org/mozilla-central/rev/643150e6bb9d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.