956902 - [B2G][First Time Experience] User is able to access and become stuck in Settings app during FTU/FTE

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Brogan Zumwalt [Inactive]]

Description:
If user clicks on any privacy information link during the FTE/FTU they may encounter an email link which, if clicked on, takes user to email app setup. On email setup screen user is able to access notification bar. Clicking on the gear icon on bottom right takes user to Settings app. Once in settings app, user is unable to return to FTU.

Repro Steps:
1) Updated Buri to Build ID: 20140106040201
2) Open Settings app
3) Select Device Information>More Information>Reset Phone
4) Press Reset
5) Enable Data
6) Select Next until Geolocation screen appears
7) Press "More about your privacy" link
8) Select Everything.me
9) Scroll to bottom of page and select email link "[e-mail]"
10) Select "OK" on email setup notification
11) Drag finger down from top of screen to open notifications bar
12) Select Gear icon to open Settings app

Actual:
User is able to access Settings app in FTU and is unable to exit.

Expected:
User is unable to access Settings app in FTU.

Environmental Variables
Device: Buri v 1.4 Mozilla RIL
Build ID: 20140106040201
Gecko: http://hg.mozilla.org/mozilla-central/rev/14ac61461f2a
Gaia: 9a222ac02db176e47299bb37112ae40aeadbeca7
Platform Version: 29.0a1
Firmware Version: V1.2_20131115

Notes:
Repro frequency: 3/3, 100%
See attached: video clip - http://www.youtube.com/watch?v=3yrqfDGGhes
Optional workarounds that may have been identified: Long pressing power button allows user to restart or power off phone. When powered back on, phone reloads FTU.

Comment 1

[Jason Smith [:jsmith]]

Does this reproduce on 1.3 or 1.2?

Comment 2

[Brogan Zumwalt [Inactive]]

Unable to fully test issue on 1.3 & 1.2 due to divergent behavior causing what appears to be a new bug on step 10 of Comment 0 repro steps. 

Issue: After selecting "Ok" on email setup notification, user is taken back to privacy agreement page. At this point the page's close button no longer functions. In addition the user is able to access the notification bar by sliding their finger down the screen, but pressing the Gear icon has no effect. 

This issue may be related to this bug so I am not sure if I should file a new bug, please advise.

1.3
Environmental Variables
Device: Buri v 1.3 Mozilla RIL
Build ID: 20140106004001
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/a43cb4b322d3
Gaia: 35a60b82f8cf2d759939a350e2dadbb9d8b2f5dc
Platform Version: 28.0a2 
Firmware Version: V1.2_US_20131115


1.2
Environmental Variables
Device: Buri v 1.2 COM RIL
Build ID: 20140106004001
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/d552c08a72d0
Gaia: 8441587c3b352e052fee07665c21fd192540f19f
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Firmware Version: V1.2_US_20131115

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Hi,

I would suggest a more generic name for the bug, but will first Fernando to comment here.

The problem itself is with the status bar during the FTU, in this case was email notification, but if we receive a sms during ftu we will be in the same situation.

IMHO, this requires a deep discussion about what should happen when we are in ftu and we receive a notification.

Cheers,
F.

Comment 4

[Fernando Campo (:fcampo)]

This is indeed a known bug (at least the part where user is able to access the notification bar), which I thought it was solved in the windows manager. But this new scenario where we are able to navigate to other app (email link) is completely new for me.

As for the discussion, I think this is a matter of UX, so I would ping the people responsible for FTU, which I think it's Jaqueline and Peter, but I'm not sure of their bugzilla handlers, so ni? for general UX

Also pinging Alive as I think I remember he was in charge of the window manager changes that disabled notifications during FTU, and he might have an opinion in the matter also.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Proposed change:
When FTULauncher is running, disable UtilityTray.

Comment 6

[Stephany Wilkes]

Flagging Jacqueline who owns FTE.

Comment 7

[Jacqueline Savory [:jsavory] UX]

Sorry for the delay on this one. I agree with Alive that the notifications and utility tray should be disabled during the FTU process. 

I think the user's expectation is to begin using their device after FTU is complete. We don't want users to be able to skip FTU or not be able to return to it.

Comment 8

[Joshua Mitchell (Inactive)]

[Blocking Requested - why for this release]: User is able to bypass the rest of the FTU / Once in settings app, user is unable to return to FTU or Homescreen

This issue still occurs - most recently on Flame 2.0 KK base

Device: Flame 2.0
Build ID: 20141024000201
Gaia: 86d83f4b4111ca45ebc92ca779348cc966f43cff
Gecko: f8432250efb7
Version: 32.0 (2.0)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

-----------------------------------------------------------------------------------
Issue does NOT occur in 2.1 and 2.2 - The user can not pull down the notification bar at step 11 in the STR

Comment 9

[Manuel Casas Barrado [:mancas]]

Attachment: Utility tray disabled when FTU is running

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 8514074 [details] [review]
Utility tray disabled when FTU is running

lgtm :)

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/5f3126b10569f4f252b2babfba5442b66605740b

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Wait, what?!?! This was a v2.0 patch? Why did you request checkin without approval or any indication of whether other branches were affected?

Reverted:
v2.0: https://github.com/mozilla-b2g/gaia/commit/fe2167fa5314c7e71c143a590914cbf3771905a8

Please take the time to familiarize yourself with the branch landing policies before requesting checkin in the future. These policies have been in effect for months now.
https://wiki.mozilla.org/Release_Management/B2G_Landing#v2.0

Comment 13

[Wayne Chang [:wchang]]

I see this as a corner case (with a somewhat cumbersome but possible recovery) and comment 8 suggests that this has been fixed on 2.1/2.2 - Not blocking, but since patch is available, partners can include to their product as needed.

Comment 14

[Manuel Casas Barrado [:mancas]]

Oh sorry! It was a terrible mistake Ryan, I thought it was another bug.

As Wayne said, it is a corner case, so I'm going to request the approval and then we can merge it if needed.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

OK, thanks.

Comment 16

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8514074 [details] [review]
Utility tray disabled when FTU is running

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): No regression
[User impact] if declined: This is an edge case. If the user opens settings from the utility tray, he/she will be unable to return to FTU or Homescreen
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: No

Comment 17

[Manuel Casas Barrado [:mancas]]

Attachment: Utility tray disabled when FTU is running

Added a new pull request because the previous one has been closed.

Comment 18

[Manuel Casas Barrado [:mancas]]

Is this patch still need to be landed in branch 2.0?

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Sorry, these slip through the cracks sometimes when they aren't uplifts from master :(

v2.0: https://github.com/mozilla-b2g/gaia/commit/366aaa19ac474dc58b79d62a91cff41756ae9dfe

Comment 20

[Boon]

This bug has been verified as "pass" on latest Nightly build of Flame v2.0 by the STR in Comment 0.

Actual results:  User can't pull down the notification bar at step 11. And user can sign in email account, then can be able to return to FTU/Homescreen.
See attachment:  verified_v2.0.3gp
Reproduce rate:  0/6


Device: Flame v2.0 build(Verified)
Build ID               20150623000204
Gaia Revision          5552bf529d3d6775a968942e9afa6c1d4037362c
Gaia Date              2015-05-21 14:42:19
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/5a1353911c67
Gecko Version          32.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150623.032718
Firmware Date          Tue Jun 23 03:27:29 EDT 2015
Bootloader             L1TC000118D0

Comment 21

[Boon]

Attachment: verified_v2.0.3gp