956907 - incorrect icon used for marked state on social marks button

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

social marks has the state of its icons flipped.  this was fixed for australis when some code was reorganized, but beta/aurora still suffer form this.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: fix icons used for marked/unmarked state

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8356293 [details] [diff] [review]
fix icons used for marked/unmarked state

or markh

Comment 3

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/projects/holly/rev/757a9b2dcda5

Comment 4

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8356293 [details] [diff] [review]
fix icons used for marked/unmarked state

[Approval Request Comment]
Bug caused by (feature/regressing bug #): socialmarks.  test provider had icons switched as well, so bug was not caught visually.  I caught the issue during a refactoring of this code in australis
User impact if declined: state of social mark appears incorrectly
Testing completed (on m-c, etc.): holly
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c7fd747d6718
https://hg.mozilla.org/releases/mozilla-beta/rev/9847fa0e68e4

Comment 6

[u279076]

Do we have tests to ensure the correct icon is showing?

Comment 7

[Andrei Vaida [:avaida]]

Hi Shane,  I assume that this bug refers to the fact that the mark button (flag) was displaying its state color under Mac OS X, in an opposite way of how it should have. The correct behavior is: grey flag if the page is unmarked, red flag if the page is marked - please let me know if my assumptions are correct or not.

If my assumptions are indeed correct, then I confirm the fix on Mac OS X 10.8.5 and Mac OS X 10.9.1 using:
- the latest Beta (BuildID: 20140116125114)
- the latest Aurora (BuildID: 20140116004003)

Comment 8

[Shane Caraveo (:mixedpuppy)]

(In reply to Andrei Vaida, QA [:AndreiVaida] from comment #7)
> The correct behavior is: grey flag if the page is
> unmarked, red flag if the page is marked - please let me know if my
> assumptions are correct or not.

Hi Andrei, yes that would be correct.

Comment 9

[Andrei Vaida [:avaida]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #8)
> (In reply to Andrei Vaida, QA [:AndreiVaida] from comment #7)
> > The correct behavior is: grey flag if the page is
> > unmarked, red flag if the page is marked - please let me know if my
> > assumptions are correct or not.
> 
> Hi Andrei, yes that would be correct.

Thank you for the quick reply, marking this issue as verified.