Closed
Bug 956910
Opened 12 years ago
Closed 12 years ago
gear icon for sidebar does not appear correctly for win/lin
Categories
(Firefox Graveyard :: SocialAPI, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 29
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
References
Details
(Whiteboard: [good first verify])
Attachments
(1 file)
|
2.93 KB,
patch
|
markh
:
review+
|
Details | Diff | Splinter Review |
The new sidebar header for the social sidebar has a gear button used for changing the sidebar provider. It does not appear correctly on windows or linux.
| Assignee | ||
Comment 1•12 years ago
|
||
fixes appearance of sidebar gear button for all platforms.
Assignee: nobody → mixedpuppy
Attachment #8356356 -
Flags: review?(mhammond)
Comment 2•12 years ago
|
||
Comment on attachment 8356356 [details] [diff] [review]
fix gear icon in sidebar
Review of attachment 8356356 [details] [diff] [review]:
-----------------------------------------------------------------
I'm a little surprised we don't need explicit/max widths and heights here, but given we didn't have them before either, this looks fine to me.
Attachment #8356356 -
Flags: review?(mhammond) → review+
| Assignee | ||
Comment 3•12 years ago
|
||
| Assignee | ||
Comment 4•12 years ago
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Updated•6 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•