956945 - [B2G][Settings] Voicemail number does not update after deleting the number

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Josh Schmitt [Joshs]]

Attachment: Voice_Mail.jpg

Description:
Voicemail number doesnt update until the Settings app is forced closed

Repro Steps:
1) Updated Buri to BuildID: 20140106004001
2) Proceed to Settings app
3) Select 'Call Settings'
4) Select 'Voicemail'
5) Enter in random numbers
6) Go back and verify numbers are shown
7) Select 'Voicemail' and delete the numbers shown
8) Select 'Ok'

Actual:
The numbers are not updated in the 'Call Settings' section of the app

Expected:
The numbers update after selecting 'Ok'

Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140106004001
Gaia: 35a60b82f8cf2d759939a350e2dadbb9d8b2f5dc
Gecko: a43cb4b322d3
Version: 28.0a2
Firmware Version: V1.2_20131115

Comment 1

[Jason Smith [:jsmith]]

Does this reproduce on 1.2?

Comment 2

[Josh Schmitt [Joshs]]

The bug does reproduce in 1.2 latest build, also if the phone automatically set the voicemail number the voicemail will revert back to that number if deleted all characters.

Environmental Variables:
Device: buri 1.2 MOZ
BuildID: 20140106004001
Gaia: 8441587c3b352e052fee07665c21fd192540f19f
Gecko: d552c08a72d0
Version: 26.0

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Josh Schmitt from comment #0)
> Created attachment 8356339 [details]
> Voice_Mail.jpg
> 
> Description:
> Voicemail number doesnt update until the Settings app is forced closed

This is working fine as I can see. Are you sure you click on 'OK' button?

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

I'm able to reproduce it. Go for it.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: regression.

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Attachment: v1

Fabien, this patch fixes the issue detailed in comment #0. Actually this is no a regression but a bug we hadn't noticed yet. Would you take a look a it please? Thanks.

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/15156

Fabien, this is the PR for this bug. Feel free to review the work in github if you feel more comfortable. Thanks!

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Josh Schmitt from comment #2)
> The bug does reproduce in 1.2 latest build, also if the phone automatically
> set the voicemail number the voicemail will revert back to that number if
> deleted all characters.

This is not an issue but a certification requirement. If the VM number is in the SIM the device must use it.

Comment 9

[Fabien Cazenave [:kaze]]

Comment on attachment 8357742 [details] [diff] [review]
v1

R=me, see minor nit on your PR.

Comment 10

[José Antonio Olivera Ortega [:jaoo]]

Thanks Fabien!

Landed on Gaia master branch at https://github.com/mozilla-b2g/gaia/commit/c506ceb9287989d61c5243ac4f098de163bcd2cc

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted c506ceb9287989d61c5243ac4f098de163bcd2cc to:
v1.3: 6c82f485323b44e8ae1af1031771456a9dc5cd8d