957031 - key popups are far too brief

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P3)

Description

[Dietrich Ayala (:dietrich)]

it's up and then closed in a flash. it's not even enough time to see the letter on the popup.

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

+1 should be visible for at least 60 ms or so. Maybe more, depends a bit on how it feels.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This bug is trivial to implement after bug 1029356.

Comment 3

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#21519

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8452909 [details] [review]
mozilla-b2g:master PR#21519

According to https://bug983043.bugzilla.mozilla.org/attachment.cgi?id=8452129#9 UX is asking for a 0.1sec delay, although I can't feel any differences...

Flagging Omega for UX review, please come to me to find the phone with the fix loaded.

Comment 5

[Omega Feng [:Omega] [:馮於懋]]

Comment on attachment 8452909 [details] [review]
mozilla-b2g:master PR#21519

Looks good from UX side.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8452909 [details] [review]
mozilla-b2g:master PR#21519

We already have bug 971446, which is pure CSS change for this requirement, but targeted at 0.01 sec.
I am afraid changing this to 0.1 sec would make the keyboard more laggy, especially when you do a "swipe" on the keys or the alternative char menu.
(Maybe we could avoid this after bug 985855?)

--
Omega, could you help comment if the above is a valid concern?

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8452909 [details] [review]
mozilla-b2g:master PR#21519

Requesting review again since the swipe issue is addressed.

I am no sure I should remove the 0.01s delay CSS in this bug or in another bug.

Comment 8

[Omega Feng [:Omega] [:馮於懋]]

Comment on attachment 8452909 [details] [review]
mozilla-b2g:master PR#21519

Like Rudy mentioned, it can be tweaked on something, like:
1) When pressing on a key, the previous typing hint will dismiss immediately regardless the timeout.
2) The timeout could be 85 ms instead.

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8452909 [details] [review]
mozilla-b2g:master PR#21519

r=me, thanks.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8452909 [details] [review]
mozilla-b2g:master PR#21519

Patch updated.

Comment 11

[Omega Feng [:Omega] [:馮於懋]]

Comment on attachment 8452909 [details] [review]
mozilla-b2g:master PR#21519

Looks good from UX side!

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/d16f5e5817cf370841c937c9159432f7cdc4b5cb