Closed Bug 957031 Opened 6 years ago Closed 6 years ago

key popups are far too brief

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P3)

x86
macOS
defect

Tracking

(feature-b2g:2.1)

RESOLVED FIXED
2.0 S6 (18july)
feature-b2g 2.1

People

(Reporter: dietrich, Assigned: timdream)

References

Details

(Whiteboard: [p=1])

Attachments

(1 file)

it's up and then closed in a flash. it's not even enough time to see the letter on the popup.
+1 should be visible for at least 60 ms or so. Maybe more, depends a bit on how it feels.
This bug is trivial to implement after bug 1029356.
Assignee: nobody → timdream
Status: NEW → ASSIGNED
Depends on: 1029356
Whiteboard: [p=1]
Target Milestone: --- → 2.0 S6 (18july)
Comment on attachment 8452909 [details] [review]
mozilla-b2g:master PR#21519

According to https://bug983043.bugzilla.mozilla.org/attachment.cgi?id=8452129#9 UX is asking for a 0.1sec delay, although I can't feel any differences...

Flagging Omega for UX review, please come to me to find the phone with the fix loaded.
Attachment #8452909 - Flags: ui-review?(ofeng)
Attachment #8452909 - Flags: review?(rlu)
Comment on attachment 8452909 [details] [review]
mozilla-b2g:master PR#21519

Looks good from UX side.
Attachment #8452909 - Flags: ui-review?(ofeng) → ui-review+
Comment on attachment 8452909 [details] [review]
mozilla-b2g:master PR#21519

We already have bug 971446, which is pure CSS change for this requirement, but targeted at 0.01 sec.
I am afraid changing this to 0.1 sec would make the keyboard more laggy, especially when you do a "swipe" on the keys or the alternative char menu.
(Maybe we could avoid this after bug 985855?)

--
Omega, could you help comment if the above is a valid concern?
Attachment #8452909 - Flags: review?(rlu)
Flags: needinfo?(ofeng)
Comment on attachment 8452909 [details] [review]
mozilla-b2g:master PR#21519

Requesting review again since the swipe issue is addressed.

I am no sure I should remove the 0.01s delay CSS in this bug or in another bug.
Attachment #8452909 - Flags: review?(rlu)
Comment on attachment 8452909 [details] [review]
mozilla-b2g:master PR#21519

Like Rudy mentioned, it can be tweaked on something, like:
1) When pressing on a key, the previous typing hint will dismiss immediately regardless the timeout.
2) The timeout could be 85 ms instead.
Attachment #8452909 - Flags: ui-review+
Flags: needinfo?(ofeng)
Comment on attachment 8452909 [details] [review]
mozilla-b2g:master PR#21519

r=me, thanks.
Attachment #8452909 - Flags: review?(rlu) → review+
Comment on attachment 8452909 [details] [review]
mozilla-b2g:master PR#21519

Patch updated.
Attachment #8452909 - Flags: ui-review?(ofeng)
Comment on attachment 8452909 [details] [review]
mozilla-b2g:master PR#21519

Looks good from UX side!
Attachment #8452909 - Flags: ui-review?(ofeng) → ui-review+
master: https://github.com/mozilla-b2g/gaia/commit/d16f5e5817cf370841c937c9159432f7cdc4b5cb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
feature-b2g: --- → 2.1
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.