Closed
Bug 957075
Opened 10 years ago
Closed 10 years ago
MSVC warning: jscompartment.h(504) : warning C4805: '==' :unsafe mix of type 'js::AutoDebugModeInvalidation::<unnamed-type-needInvalidation_>' and type 'bool' in operation
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
918 bytes,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
MOZ_ASSERT_IF(needInvalidation_ != NoNeed,
needInvalidation_ == debugMode ? ToggledOn : ToggledOff);
MSVC points out that the type of needInvalidation_ != bool. In other words, there should be parentheses around the RHS.
Attachment #8356503 -
Flags: review?(shu)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8356503 [details] [diff] [review] Patch Review of attachment 8356503 [details] [diff] [review]: ----------------------------------------------------------------- Oops, thanks for parentheses.
Attachment #8356503 -
Flags: review?(shu) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c26da1b05ba
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8c26da1b05ba
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•