Closed Bug 957075 Opened 6 years ago Closed 6 years ago

MSVC warning: jscompartment.h(504) : warning C4805: '==' :unsafe mix of type 'js::AutoDebugModeInvalidation::<unnamed-type-needInvalidation_>' and type 'bool' in operation

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
MOZ_ASSERT_IF(needInvalidation_ != NoNeed,
              needInvalidation_ == debugMode ? ToggledOn : ToggledOff);

MSVC points out that the type of needInvalidation_ != bool. In other words, there should be parentheses around the RHS.
Attachment #8356503 - Flags: review?(shu)
Comment on attachment 8356503 [details] [diff] [review]
Patch

Review of attachment 8356503 [details] [diff] [review]:
-----------------------------------------------------------------

Oops, thanks for parentheses.
Attachment #8356503 - Flags: review?(shu) → review+
https://hg.mozilla.org/mozilla-central/rev/8c26da1b05ba
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.